Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

React to RDG name change in SDK for preview4 #47359

Closed
captainsafia opened this issue Mar 22, 2023 · 1 comment · Fixed by dotnet/sdk#31460
Closed

React to RDG name change in SDK for preview4 #47359

captainsafia opened this issue Mar 22, 2023 · 1 comment · Fixed by dotnet/sdk#31460
Assignees
@captainsafia
Labels
area-minimal Includes minimal APIs, endpoint filters, parameter binding, request delegate generator etc feature-rdg
Milestone
8.0-preview4

Comments

@captainsafia
Copy link
Member

captainsafia commented Mar 22, 2023 •
edited
Loading

In #47334, we renamed the RDG generator project (and assembly name) to make it clearer that it contains only one generator.

Now that the change has flown to the installer, we need to update the off-by-default logic in the SDK to react to this name change:

https://github.com/dotnet/sdk/blob/e3b39b8db045f14193a29726cb193cea8913e0dc/src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.FrameworkReferenceResolution.targets#L421-L437

This change will require updating the installer used to the build the SDK repo and updating the target above.

In the meantime, the request delegate generator will be on by default for all projects using the preview4 runtime.
@captainsafia captainsafia added this to the 8.0-preview4 milestone Mar 22, 2023
@captainsafia captainsafia self-assigned this Mar 22, 2023
@mitchdenny mitchdenny mentioned this issue Mar 23, 2023
Closed
@captainsafia captainsafia mentioned this issue Mar 27, 2023
Merged
@captainsafia
Copy link
Member Author

Verified as fixed in 8.0.100-preview.4.23210.3.

@ghost ghost locked as resolved and limited conversation to collaborators May 11, 2023
@amcasey amcasey added area-minimal Includes minimal APIs, endpoint filters, parameter binding, request delegate generator etc and removed area-runtime labels Jun 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@captainsafia captainsafia

Labels
area-minimal Includes minimal APIs, endpoint filters, parameter binding, request delegate generator etc feature-rdg
Projects
None yet
Milestone
8.0-preview4
Development

Successfully merging a pull request may close this issue.

Update off-by-default analyzers to account for rename dotnet/sdk
2 participants
@captainsafia @amcasey