Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NSwag.AspNetCore instead of Swashbuckle.AspNetCore #50133

Closed
Varorbc opened this issue Aug 17, 2023 · 5 comments
Closed

NSwag.AspNetCore instead of Swashbuckle.AspNetCore #50133

Varorbc opened this issue Aug 17, 2023 · 5 comments
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates feature-openapi
Milestone

Comments

@Varorbc
Copy link
Contributor

Varorbc commented Aug 17, 2023

Swashbuckle.AspNetCore is no longer activity, and NSwag.AspNetCore instead of Swashbuckle.AspNetCore

<PackageReference Include="Swashbuckle.AspNetCore" Version="${SwashbuckleAspNetCoreVersion}" Condition="'$(EnableOpenAPI)' == 'True'" />

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Aug 17, 2023
@davidfowl davidfowl removed the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Aug 17, 2023
@davidfowl davidfowl added this to the Discussions milestone Aug 17, 2023
@davidfowl
Copy link
Member

What do you mean Swashbuckle.AspNetCore it's no longer active?

@Varorbc
Copy link
Contributor Author

Varorbc commented Aug 17, 2023

Swashbuckle.AspNetCore is no longer activity and does not support Aot, while NSwag.AspNetCore already supports Aot, so I recommend NSwag.AspNetCore instead of Swashbuckle.AspNetCore

@davidfowl
Copy link
Member

NSwag.AspNetCore supports AOT? Can you point me to this support?

@Varorbc
Copy link
Contributor Author

Varorbc commented Aug 18, 2023

Sorry, not fully supported yet

@marinasundstrom
Copy link

marinasundstrom commented Sep 1, 2023

Personally, I prefer NSwag, but that is a choice based on feature set.

The C# client generator (NSwag) works best with NSwag's OpenAPI document.

I have been following the NSwag repository, and it is pretty much a one man operation by @RicoSuter. A lot of issues and PRs that never have been closed. So hard to keep track of what is happening. BTW. If so, can the community assist him in some way?

A major difference between the libraries is that Swashbuckle uses System.Text.Json, while the NSwag toolchain is built on Newtonsoft Json.

Overall, both libraries might be considered stable, so there are no changes unless there are serious issues.

I'm a proponent of making this a choice.

But as it is now, it is pretty easy switching out Swashbuckle for NSwag.AspNetCore. And the ASP.NET Core documentation mentions them both:

The purpose of having Swashbuckle in the template is just to have something to start with.

@marinasundstrom marinasundstrom added feature-openapi area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates labels Sep 5, 2023
@marinasundstrom marinasundstrom closed this as not planned Won't fix, can't repro, duplicate, stale Sep 6, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Oct 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates feature-openapi
Projects
None yet
Development

No branches or pull requests

3 participants