Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/*#__PURE__*/ annotations dont work well with Vite / Rollup #55286

Open
1 task done
lukedukeus opened this issue Apr 22, 2024 · 2 comments
Open
1 task done

/*#__PURE__*/ annotations dont work well with Vite / Rollup #55286

lukedukeus opened this issue Apr 22, 2024 · 2 comments
Labels
area-signalr Includes: SignalR clients and servers

Comments

@lukedukeus
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Describe the bug

running vite build thows warnings about pure annotations

1>  node_modules/@microsoft/signalr/dist/esm/Utils.js (189:0): A comment
1>
1>  "/*#__PURE__*/"
1>
1>  in "node_modules/@microsoft/signalr/dist/esm/Utils.js" contains an annotation that Rollup cannot interpret due to the position of the comment. The comment will be removed to avoid issues.

Expected Behavior

No response

Steps To Reproduce

No response

Exceptions (if any)

No response

.NET Version

No response

Anything else?

No response

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-signalr Includes: SignalR clients and servers label Apr 22, 2024
@daomtthuan
Copy link

daomtthuan commented Apr 23, 2024

+1

It was fixed at this
rollup/rollup#5324

hmm, or not 🤔

@drewkill32
Copy link

I'm having the issue and it it a bug in the javascript signalR client. Rollup expects the "/#PURE/" annotations on function calls or constructor invocation, not on module function declaration. Rollup REPL

I created PR #55496

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-signalr Includes: SignalR clients and servers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants