Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dotnet publish (3.0) #10512

Closed
mkArtakMSFT opened this issue Sep 24, 2019 · 11 comments
Closed

dotnet publish (3.0) #10512

mkArtakMSFT opened this issue Sep 24, 2019 · 11 comments

Comments

@mkArtakMSFT
Copy link
Member

From @pranavkm on Monday, September 23, 2019 6:04:07 PM

From @zygimantas on Monday, September 23, 2019 5:46:20 PM

[Enter feedback here]

.NET 3.0 breaking change - I had to change after upgrade from 2.2 to 3.0:

dotnet publish --configuration=Release --no-restore --output=../../dist src/Website

to

dotnet publish --configuration=Release --no-restore --output=dist src/Website


Document Details

Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

Copied from original issue: dotnet/AspNetCore.Docs#14494

Copied from original issue: dotnet/aspnetcore#14262

@mkArtakMSFT
Copy link
Member Author

From @pranavkm on Monday, September 23, 2019 6:04:08 PM

From @Rick-Anderson on Monday, September 23, 2019 5:50:31 PM

@pranavkm who can review dotnet publish --configuration=Release --no-restore --output=dist src/Website

@mkArtakMSFT
Copy link
Member Author

From @pranavkm on Monday, September 23, 2019 6:04:10 PM

From @zygimantas on Monday, September 23, 2019 5:55:09 PM

Solution structure is:

/src/Website/Website.csproj
App.sln

@mkArtakMSFT
Copy link
Member Author

From @pranavkm on Monday, September 23, 2019 6:04:11 PM

From @zygimantas on Monday, September 23, 2019 5:56:23 PM

Error in 3.0-alpine docker container was:

COPY failed: stat /var/lib/docker/overlay2/e8eea87e7e5692f90bc8ae70e3cd6347a75dada2390362a1f1241445aab520be/merged/app/dist: no such file or directory

@mkArtakMSFT
Copy link
Member Author

From @pranavkm on Monday, September 23, 2019 6:04:46 PM

@vijayrkn does this seem familiar?

@mkArtakMSFT
Copy link
Member Author

From @vijayrkn on Monday, September 23, 2019 6:18:59 PM

No. This is just plain 'dotnet publish'.

Adding @nguerrera

@mkArtakMSFT
Copy link
Member Author

From @zygimantas on Monday, September 23, 2019 6:31:17 PM

Probably it's unrelated, but I use 3.0-alpine SDK image, but I haven't upgraded the code yet, so <TargetFramework>netcoreapp2.2</TargetFramework> is still in csproj

@mkArtakMSFT
Copy link
Member Author

From @nguerrera on Monday, September 23, 2019 6:38:43 PM

This was an intentional change and should be documented as such.

There was some discussion of including it in docs/release notes on https://github.com/dotnet/cli/issues/4765, but seems not to have happened. It has been this way in every 3.0 preview.

I believe this would best be tracked as a docs issue. cc @KathleenDollard @livarcocc

@WeihanLi
Copy link
Contributor

WeihanLi commented Sep 24, 2019

the same problem met, that's really a breaking change(if not a bug), a bunch of dockerfile had to update 😢

@dasMulli
Copy link
Contributor

The change was made for a major version that semantically allows breaks but you probably needed to update your docker files for 3.0 anyway.
Meanwhile people would open issues that the way the output paths are handled seem just wrong and unnatural. I'd be interested to know if you think that what you needed to change to feels better given the current working directory and location of project and output directory (apart from the obvious pain of migration which I am sorry for).

@zygimantas
Copy link

3.0 way is more natural

@livarcocc
Copy link
Contributor

This change was by design and aligns the CLI with the majority of other command line tools out there regarding this behavior.

@msftgits msftgits transferred this issue from dotnet/cli Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants