Copy runtimeOptions from project.json into runtimeconfig.json

[livarcocc]

Steps to reproduce

Adding the following lines to project.json has no effect on the content of the [app].runtimeconfig.json that is created in bin/Debug/…

"runtimeOptions": {
"configProperties": {
"System.GC.Server": true,
"System.GC.Concurrent": true
}
}

Expected behavior

The runtimeOptions should show up at runtimeconfig.json.

Actual behavior

Runtimeoptions from project.json is not moved over.

[livarcocc]

cc @anurse @schellap @gkhanna79 So, should we blindly move whatever is under runtimeoptions in the project.json to the runtimeoptions of runtimeconfig.json?

Do we have to do anything smart about it?

[schellap]

That is correct. Except you should remove rollforward or probe paths etc, if specified based on the scenarios like build for example (yesterday's stuff)

[livarcocc]

@schellap Remove it for publish, right?

[schellap]

yeah, but specify it to false for build also right?
you might want to add to the probe paths the nuget cache.

[livarcocc]

For rollover you mean? If it is never true, why do we need it again? Also, if they do specify it and we will not honor it, should we warn or something like that?

[schellap]

Basically, I am saying you might need to merge the config with the scenario. If they specified true, for build do you want to turn it off forcefully, and add .nuget cache to the probe list if they didn't specify. Stuff like that... basically the merge operation needs to be considered.

[schellap]

We can get away with runtimeOptions.configProperties for now to enable ASP.NET. But how config in project.json merges with scenario can come for RTM.

https://github.com/dotnet/cli/blob/rel/1.0.0/Documentation/specs/runtime-configuration-file.md

[livarcocc]

We will copy over the properties from project.json runtimeoptions to runtimeoptions of runtimeconfig.json, including additionalprobingpath and rollforward.

[gkhanna79]

@livarcocc When do you expect to have this resolved?

[livarcocc]

I intend to sent it out for PR tomorrow.