Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debugger cannot restore with newest builds of the CLI ('coreclr.ad7Engine.json does not exist') #5711

Closed
TheRealPiotrP opened this issue Apr 13, 2016 · 4 comments
Closed

Debugger cannot restore with newest builds of the CLI ('coreclr.ad7Engine.json does not exist') #5711

TheRealPiotrP opened this issue Apr 13, 2016 · 4 comments
Assignees
@eerhardt
Milestone
1.0.0-rc2

Comments

@TheRealPiotrP
Copy link
Contributor

Steps to reproduce

dotnet/vscode-csharp#181

Expected behavior

dotnet/vscode-csharp#181

Actual behavior

dotnet/vscode-csharp#181

Environment data

dotnet --info output:
@TheRealPiotrP
Copy link
Contributor Author

@brthor, while fixing this regression, can you please also fill the test gap that let this issue come through? It looks like the regressed capability was added near here: dotnet/cli@a71112c

@eerhardt eerhardt assigned eerhardt and unassigned brthor Apr 13, 2016
@eerhardt
Copy link
Member

Taking ownership to fix

@eerhardt
Copy link
Member

Ok, I added back in this line:

https://github.com/dotnet/cli/pull/2220/files#diff-21237ad3a7decd8d9b62b36289e2760dL146

And the coreclr.ad7Engine.json file is being published again.

eerhardt referenced this issue in eerhardt/cli Apr 13, 2016
@eerhardt
Add back in copying of RuntimeAssets during publish.
cc47904 
Any NuGet packages that had contentFiles weren't getting the content files added to the published output directory.  This breaks things like debugging in VS Code.

Fix #2459
@brthor
Copy link
Contributor

brthor commented Apr 13, 2016

The intention of https://github.com/dotnet/cli/pull/2220/files#diff-21237ad3a7decd8d9b62b36289e2760dR176

was to replicate the function of that line without copying the host of the current platform at the same time.

eerhardt referenced this issue in eerhardt/cli Apr 13, 2016
@eerhardt
Add back in copying of RuntimeAssets during publish.
4a950e6 
Any NuGet packages that had contentFiles weren't getting the content files added to the published output directory.  This breaks things like debugging in VS Code.

Fix #2459
@leecow leecow changed the title Debugger cannot restore with newest builds of the CLI ('coreclr.ad7Engine.json does not exist') Debugger cannot restore with newest builds of the CLI ('coreclr.ad7Engine.json does not exist') Apr 13, 2016
eerhardt referenced this issue in eerhardt/cli Apr 13, 2016
@eerhardt
Add back in copying of RuntimeAssets during publish.
aeaf8f0 
Any NuGet packages that had contentFiles weren't getting the content files added to the published output directory.  This breaks things like debugging in VS Code.

Fix #2459
@msftgits msftgits transferred this issue from dotnet/cli Jan 31, 2020
@msftgits msftgits added this to the 1.0.0-rc2 milestone Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eerhardt eerhardt

Labels
None yet
Projects
None yet
Milestone
1.0.0-rc2
Development

No branches or pull requests
4 participants
@TheRealPiotrP @eerhardt @msftgits @brthor