Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding buildOptions\embed causes resources to be skipped from being embedded #5951

Closed
pranavkm opened this issue May 2, 2016 · 10 comments
Closed
Assignees
Labels
Milestone

Comments

@pranavkm
Copy link
Contributor

pranavkm commented May 2, 2016

Steps to reproduce

  1. Clone https://github.com/aspnet/Microsoft.Data.Sqlite/ and checkout e00935cd02226b112b49a5221106e0650c53bf4a
  2. Build src/Microsft.Data.Sqlite. Notice that the generated binary has the resource file.
  3. Modify the project.json to change resource node to buildOptions/embed/include. Build it again

Expected behavior

The generated binary should include the resx file.

Actual behavior

The generated binary is missing the resx file.

Environment data

dotnet --info output:
1.0.0-rc2-002543

Specifying the resx file in the embed\include array works.

@pranavkm
Copy link
Contributor Author

pranavkm commented May 2, 2016

cc @ajaybhargavb

@ajaybhargavb ajaybhargavb self-assigned this May 2, 2016
@pranavkm
Copy link
Contributor Author

pranavkm commented May 2, 2016

Possibly related: Adding items to buildOptions\embed\include does not exclude them. I have to explicitly add items to buildOptions/compile/exclude.

@ajaybhargavb
Copy link
Contributor

Adding items to buildOptions\embed\include does not exclude them. I have to explicitly add items to buildOptions/compile/exclude.

I investigated this and it is not related to this issue. Could you please file a new issue?

@TheRealPiotrP
Copy link
Contributor

@ajaybhargavb I assume you want to get this into RC2. Please move it out to RTM if that's not the case.

@pranavkm
Copy link
Contributor Author

pranavkm commented May 3, 2016

It would be nice to fix this in RC2. Adding a compile exclude causes dotnet build to succeed, but no binary is produced without this fix. It's not entirely intuitive what is required to fix it.

@mellinoe
Copy link
Contributor

mellinoe commented May 3, 2016

I'm hitting this as well. I get no warning or anything, but the resource mentioned in the "embed" item is not included in the compiled binary.

@mellinoe
Copy link
Contributor

mellinoe commented May 3, 2016

I see this announcement now: aspnet/Announcements#175. It seems that my syntax is wrong.

@ajaybhargavb
Copy link
Contributor

@piotrpMSFT, is there any place in cli repo or the dotnet org that this announcement can be linked to?

@TheRealPiotrP
Copy link
Contributor

@blackdwarf can you help with communication here?

@TheRealPiotrP
Copy link
Contributor

Fixed by dotnet/cli#2822

@msftgits msftgits transferred this issue from dotnet/cli Jan 31, 2020
@msftgits msftgits added this to the 1.0.0-rc2 milestone Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants