Skip to content
This repository has been archived by the owner on Mar 17, 2021. It is now read-only.

perfcollect: crossgen Trusted_Platform_Assemblies key no longer works #104

Open
ezsilmar opened this issue May 24, 2019 · 0 comments
Open

Comments

@ezsilmar
Copy link

Hello,

There was a PR in coreclr which changed the public API of crossgen tool (dotnet/coreclr#23462). Instead of /Trusted_Platform_Assemblies path[:path...] it now uses /r path [/r path...]. We need to update how perfcollect uses crossgen to respect the new key.

WIP is here: https://github.com/criteo-forks/corefx-tools/tree/crossgen_fix . For now I did a simple conversion. However I thought that maybe we should check crossgen version in perfcollect to support both old and new formats.

What do you think? Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant