Release build legs are failing for NetCoreCheck

[mthalman]

Release build legs are failing in main branch:

      "D:\workspace\_work\1\s\artifacts\obj\win-x64.Release\native\INSTALL.vcxproj" (rebuild target) (1) ->
         "D:\workspace\_work\1\s\artifacts\obj\win-x64.Release\native\ALL_BUILD.vcxproj" (default target) (3:2) ->
         "D:\workspace\_work\1\s\artifacts\obj\win-x64.Release\native\projects\NetCoreCheck\EXE\NetCoreCheck.vcxproj" (default target) (5:2) ->
         (Link target) -> 
           LINK : fatal error C1047: The object or library file 'D:\workspace\_work\1\s\.dotnet\packs\Microsoft.NETCore.App.Host.win-x64\5.0.2\runtimes\win-x64\native\libnethost.lib' was created by a different version of the compiler than other objects like 'NetCoreCheck.dir\Release\FileLogger.obj'; rebuild all objects and libraries with the same compiler [D:\workspace\_work\1\s\artifacts\obj\win-x64.Release\native\projects\NetCoreCheck\EXE\NetCoreCheck.vcxproj]
           LINK : fatal error LNK1257: code generation failed [D:\workspace\_work\1\s\artifacts\obj\win-x64.Release\native\projects\NetCoreCheck\EXE\NetCoreCheck.vcxproj]
  
  
         "D:\workspace\_work\1\s\artifacts\obj\win-x64.Release\native\INSTALL.vcxproj" (rebuild target) (1) ->
         "D:\workspace\_work\1\s\artifacts\obj\win-x64.Release\native\ALL_BUILD.vcxproj" (default target) (3:2) ->
         "D:\workspace\_work\1\s\artifacts\obj\win-x64.Release\native\projects\NetCoreCheck\CA\NETCoreCheckCA.vcxproj" (default target) (4:2) ->
           LINK : fatal error C1047: The object or library file 'D:\workspace\_work\1\s\.dotnet\packs\Microsoft.NETCore.App.Host.win-x64\5.0.2\runtimes\win-x64\native\libnethost.lib' was created by a different version of the compiler than other objects like 'NETCoreCheckCA.dir\Release\MsiLogger.obj'; rebuild all objects and libraries with the same compiler [D:\workspace\_work\1\s\artifacts\obj\win-x64.Release\native\projects\NetCoreCheck\CA\NETCoreCheckCA.vcxproj]
           LINK : fatal error LNK1257: code generation failed [D:\workspace\_work\1\s\artifacts\obj\win-x64.Release\native\projects\NetCoreCheck\CA\NETCoreCheckCA.vcxproj]
  
      0 Warning(s)
      4 Error(s)

https://dev.azure.com/dnceng/public/_build/results?buildId=1121249&view=results

cc @MSLukeWest, @NikolaMilosavljevic

[NikolaMilosavljevic]

We've seen this in the past, but it was fixed several months ago.

@MSLukeWest are you aware of any changes that could have caused this?

@mthalman does your local builds work fine? Release and debug?

[mthalman]

Release config fails locally too.

[MSLukeWest]

@NikolaMilosavljevic I'm not aware of any changes that could have caused this, the build worked fine the last time I edited NETCoreCheck a couple months ago. If you'll recall, last time this was fixed by updating the .NET Toolset, see https://github.com/dotnet/deployment-tools/pull/87/files. Has the toolset been updated since then?

@mthalman If you're blocked by this just go ahead and change this property to true:

deployment-tools/eng/Subsets.props

Line 73 in 3c246e5

<DisableClickOnceNativeBuild>false</DisableClickOnceNativeBuild>

That will disable building NETCoreCheck for now, which is OK because there's currently no planned updates.