Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A single word in the topic title may be broken at arbitrary points (default template css) #234

Closed
svver opened this issue Mar 24, 2016 · 7 comments
Assignees
Labels
bug A bug to fix customization Site customization, custom styles, headers, footers and layouts template The stock site template
Milestone

Comments

@svver
Copy link

svver commented Mar 24, 2016

The default template CSS set word-break property to "break-all" for h1,h2 and so on, so the title may look ugly. For me this looks this way:
image
Is this a desired behaviour?

@simonmurdock
Copy link

I've noticed this too, it's definitely not desirable from my perspective. Maybe to accommodate very long unbroken strings in namespaces etc.

@svver
Copy link
Author

svver commented Mar 25, 2016

@simonmurdock, indeed, here is an example where a long namespace takes tho lines.
image
If I set "word-break" to "normal" all the namespace goes to the new line. In case of a very long namespace this will be a problem.

I would split namespaces using "." as a separator and then insert an i tag with a space and set font-size to 1px:

Namespace Microsoft.<i> </i>CodeAnalysis.<i> </i>Workspaces.<i> </i>Dnx

<style>
   i {font-size: 1px}
</style>

@simonmurdock
Copy link

That makes sense. Would be good to move that "improve this doc" button somewhere else and reduce the font size a bit.

@hellosnow
Copy link
Contributor

We just moved "improve this doc" to the right navigation via #626 , and we will have action items to refactor the word wrap.

@richardschneider
Copy link
Contributor

How about surrounding the dot with U+200B ZERO WIDTH SPACE. See #1222.

@vicancy vicancy added template The stock site template customization Site customization, custom styles, headers, footers and layouts bug A bug to fix priority-3 labels May 9, 2017
@vicancy vicancy added this to the v2.18 milestone May 9, 2017
@hellosnow hellosnow modified the milestones: Near term, v2.18 May 10, 2017
@hellosnow
Copy link
Contributor

Sorry for the late updates, we fixed the title space by #1695 , the github pages will be refreshed after v2.18.0 is released.

@hellosnow
Copy link
Contributor

The code is in dev branch and not in master yet, the github pages will be refreshed after v2.19 is released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug to fix customization Site customization, custom styles, headers, footers and layouts template The stock site template
Projects
None yet
Development

No branches or pull requests

5 participants