Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] PDF producer's version information is missing on PDF that generated by docfx pdf command #9843

Closed
filzrev opened this issue Apr 7, 2024 · 0 comments · Fixed by #9851
Labels
bug A bug to fix pdf Produce PDF as the output format

Comments

@filzrev
Copy link
Contributor

filzrev commented Apr 7, 2024

Describe the bug
PDF producer property is not written as expected.

To Reproduce

  1. Open PDF file generated by docfx.
  2. Confirm PDF document property.
  3. docfx () text is displayed as producer.

Expected behavior
PDF generator exe name with version information is displayed (e.g. 'docfx (2.76.0)`)

Additional context
Currently producer property is set on following line.

var producer = $"docfx ({typeof(PdfBuilder).Assembly.GetCustomAttribute<AssemblyVersionAttribute>()?.Version})";

But AssemblyVersionAttribute is missing on Docfx.App assembly.

It might be better to use name of Assembly.GetEntryAssembly().Name as producer name.
And use AssemblyFileVersionAttribute version instead.

@filzrev filzrev added the bug A bug to fix label Apr 7, 2024
@yufeih yufeih added the pdf Produce PDF as the output format label Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug to fix pdf Produce PDF as the output format
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants