Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker.DotNet, X509, BasicAuth: Should be signed releases #102

Closed
jterry75 opened this issue Jul 18, 2016 · 2 comments
Closed

Docker.DotNet, X509, BasicAuth: Should be signed releases #102

jterry75 opened this issue Jul 18, 2016 · 2 comments
Milestone

Comments

@jterry75
Copy link
Contributor

In order for uses to include Docker.DotNet and other binaries in the GAC (for non .NET Core scenarios) they need to be signed.

@jterry75 jterry75 added this to the v2.125 milestone Jul 18, 2016
@jstarks jstarks modified the milestones: v2.125, v2.124.2 Jul 18, 2016
@jterry75 jterry75 modified the milestones: v3.126, v2.124.2 Jul 28, 2017
@jterry75 jterry75 mentioned this issue Jul 28, 2017
@jterry75
Copy link
Contributor Author

Looking for feedback here:

I don't want to limit the communities ability to create privates and use them. Does anyone know the best practices for .NET signing binaries in the public? From what I can tell people include the Key.snk in the project and you can sign the binaries on your own if building privates. However this doesn't offer any protections of authenticity given the key is public if we use this same key for NuGet. For official releases to NuGet I would sign these with a private key known only to me. (Uh... Hit by a bus scenario anyone?)

The issue I see here is mostly that these two keys will never be the same and thus people who are making privates will be constantly switching between strong names of different keys. Are there any issues here other than requiring rebuild? Maybe that isn't even a problem since if you are using privates you are rebuilding anyways. Ideas?

@galvesribeiro
Copy link
Member

@jterry75 I would suggest you to ping @sergeybykov

He is the head of Orleans project and we sign Orleans public bits on every release. I know it is a costly process but he may be able to guide you with the internal MSFT process to get there.

As for public custom builds, anyone can tap in the build process using their preferable tool and sign the dll.

@jterry75 jterry75 closed this as not planned Won't fix, can't repro, duplicate, stale Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants