Add dependency to Microsoft.Bcl.Async

[maitredede]

Hi,

Can you add nuget dependency to Microsoft.Bcl.Async ?
Without it, I have exceptions about a missing assembly...

Thanks

[ahmetb]

I wonder why we need that. We were able to use it without Microsoft.Bcl.Async. What is the full exception you get?

[maitredede]

FileNotFoundException for assembly : Microsoft.Threading.Tasks, Version=1.0.12.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a

[ahmetb]

@jgarverick any ideas? looks like a PCL issue.

[maitredede]

Why not making a plain 4.5 assembly ? You could add another project, but that does not rely on BCL assemblies/packages...

[jgarverick]

What target(s) are you trying to build for that it's giving you grief?
Just a plain ol' .NET 4.5 app?

We wanted to keep the code base in one compact library to make it easier to
maintain, hence the lack of pure 4.5 assembly. I don't see any issue with
adding a dependency in the NuSpec file to make sure it pulls in BCL.Async,
though. @ahmetalpbalkan, thoughts?

On Mon, Mar 9, 2015 at 4:45 AM, Damien DALY notifications@github.com
wrote:

Why not making a plain 4.5 assembly ? You could add another project, but
that does not rely on BCL assemblies/packages...

—
Reply to this email directly or view it on GitHub
#18 (comment)
.

[maitredede]

I am just asking :)
I compile only 4.5 assemblies, (or 4.5.1). No BCL.
I don't know if having the BCL libs in pure 4.5 can have any impacts (that's why I am asking).

[ahmetb]

@jgarverick I don't see any issues either. It's just I'm wondering why did this suddenly become a dependency.

[jgarverick]

It's always been a dependency, just not officially in the NuGet package
that's deployed AFAIK. When I started developing my app using the framework
I had to add it as well. I probably should have added it to the spec then
but I didn't think of it.
On Mon, Mar 9, 2015 at 12:52 PM Ahmet Alp Balkan notifications@github.com
wrote:

@jgarverick https://github.com/jgarverick I don't see any issues
either. It's just I'm wondering why did this suddenly become a dependency.

—
Reply to this email directly or view it on GitHub
#18 (comment)
.

[ahmetb]

Can you please send a PR? I wasnt aware of this :-) 

—Alp
http://alp.im

On Mon, Mar 9, 2015 at 3:11 PM, Josh Garverick notifications@github.com
wrote:

It's always been a dependency, just not officially in the NuGet package
that's deployed AFAIK. When I started developing my app using the framework
I had to add it as well. I probably should have added it to the spec then
but I didn't think of it.
On Mon, Mar 9, 2015 at 12:52 PM Ahmet Alp Balkan notifications@github.com
wrote:

@jgarverick https://github.com/jgarverick I don't see any issues
either. It's just I'm wondering why did this suddenly become a dependency.

—
Reply to this email directly or view it on GitHub
#18 (comment)
.

---

Reply to this email directly or view it on GitHub:
#18 (comment)

[ahmetb]

Fixed now.