Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hard-coded location and resource group name ought to be env variables #334

Closed
Monte-Christo opened this issue Jan 29, 2024 · 0 comments · Fixed by #338
Closed

Hard-coded location and resource group name ought to be env variables #334

Monte-Christo opened this issue Jan 29, 2024 · 0 comments · Fixed by #338
Assignees
@IEvangelist
Labels
deployment Content related to deployment. doc-bug Problem with the content; needs to be fixed [org][type][category] dotnet-aspire/svc Pri1 High priority, do before Pri2 and Pri3 📌 seQUESTered Identifies that an issue has been imported into Quest.

Comments

@Monte-Christo
Copy link

Monte-Christo commented Jan 29, 2024 •
edited by github-actions bot
Loading

Type of issue

Code doesn't work

Description

[Enter feedback here]
The command

az group create --location westus --name aspiretoacarg

ought to read

az group create --location $env:LOCATION --name $env:RESOURCE_GROUP

Page URL

https://learn.microsoft.com/en-us/dotnet/aspire/deployment/azure/aca-deployment?tabs=visual-studio%2Cinstall-az-windows%2Cpowershell

Content source URL

https://github.com/dotnet/docs-aspire/blob/main/docs/deployment/azure/aca-deployment.md

Document Version Independent Id

1362fc62-686d-2b3f-c139-7725fc8dca5f

Article author

@IEvangelist

Associated WorkItem - - 205858](https://dev.azure.com/msft-skilling/Content/_workitems/edit/205858)
@IEvangelist IEvangelist self-assigned this Jan 30, 2024
@IEvangelist IEvangelist mentioned this issue Jan 30, 2024
Merged
@dotnet-bot dotnet-bot removed the ⌚ Not Triaged Not triaged label Jan 30, 2024
@IEvangelist IEvangelist added 🗺️ reQUEST Triggers an issue to be imported into Quest. Pri1 High priority, do before Pri2 and Pri3 doc-bug Problem with the content; needs to be fixed [org][type][category] deployment Content related to deployment. labels Jan 30, 2024
@github-actions github-actions bot added 📌 seQUESTered Identifies that an issue has been imported into Quest. and removed 🗺️ reQUEST Triggers an issue to be imported into Quest. labels Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@IEvangelist IEvangelist

Labels
deployment Content related to deployment. doc-bug Problem with the content; needs to be fixed [org][type][category] dotnet-aspire/svc Pri1 High priority, do before Pri2 and Pri3 📌 seQUESTered Identifies that an issue has been imported into Quest.
Projects
No open projects
dotnet/docs January 2024 sprint
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix hardcoded values in ACA deploy include IEvangelist/docs-aspire
3 participants
@IEvangelist @Monte-Christo @dotnet-bot