Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

supported values of PixelFormat should be enumerated #924

Open
macginitie opened this issue Sep 22, 2018 — with docs.microsoft.com · 6 comments
Open

supported values of PixelFormat should be enumerated #924

macginitie opened this issue Sep 22, 2018 — with docs.microsoft.com · 6 comments
Labels
area-WPF Issues or PRs that relate to WPF or XAML. doc-enhancement Improve the current content dotnet-api/prod Pri1 Indicates issues/PRs that are high priority
Milestone
Backlog

Comments

@macginitie docs.microsoft.com
Copy link

If it is the case that some values in the enumeration are not supported

Document Details

⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.
@taikodragon docs.microsoft.com
Copy link

PixelFormats.BGRA32 is not supported for instance.

@taikodragon docs.microsoft.com
Copy link

PixelFormatEnum.Pbgra32 is the only support type according to the reference source here: https://referencesource.microsoft.com/#PresentationCore/Core/CSharp/System/Windows/Media/Imaging/RenderTargetBitmap.cs line 64

@mairaw
Copy link
Contributor

mairaw commented Nov 19, 2018 •
edited

@OliaG @SamBent can you comment on this? It also seems we're missing docs for a couple of exceptions being thrown by this constructor.
It seems that the only valid values would be Default or Pbgra32. And Default gets changed to Pbgra32.

@SamBent
Copy link

SamBent commented Nov 19, 2018

@mairaw I agree with your remarks.
A fine point that may affect how the doc gets worded: The caller of RenderTargetBitmap ctor is not obliged to use the PixelFomats enum directly; for example, you can get the format from another BitmapSource: new RenderTargetBitmap(..., myBitmapSource.Format). But ultimately the format has to agree with PixelFormats.Default or PixelFormats.Pgbra32.

@mairaw mairaw self-assigned this Nov 19, 2018
@mairaw
Copy link
Contributor

mairaw commented Nov 19, 2018

Ok, thanks @SamBent!

@BillWagner BillWagner transferred this issue from dotnet/docs Nov 20, 2018
@dotnet-bot dotnet-bot added untriaged New issue has not been triaged by the area owner Source - Docs.ms and removed rerun-labels labels Nov 20, 2018
@mairaw mairaw added doc-enhancement Improve the current content and removed untriaged New issue has not been triaged by the area owner labels Nov 26, 2018
@mairaw mairaw added this to To do in Sprint 145 (11/26/2018 - 12/14/2018) via automation Nov 26, 2018
@mairaw mairaw added this to To do in Sprint 146 (12/17/2018 - 01/04/2019) via automation Dec 17, 2018
@mairaw mairaw added this to To do in Sprint 147 (01/07/2019 - 01/25/2019) via automation Dec 22, 2018
@mairaw mairaw added the Pri1 Indicates issues/PRs that are high priority label Jan 25, 2019
@mairaw
Copy link
Contributor

mairaw commented Jan 25, 2019

Moving to the backlog until I can actually pick this up to start working on it.

@Jozkee Jozkee added the area-WPF Issues or PRs that relate to WPF or XAML. label Sep 8, 2020
@mairaw mairaw removed their assignment Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-WPF Issues or PRs that relate to WPF or XAML. doc-enhancement Improve the current content dotnet-api/prod Pri1 Indicates issues/PRs that are high priority
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
8 participants
@BillWagner @taikodragon @dotnet-bot @mairaw @SamBent @Jozkee @PRMerger10 @macginitie