Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documented IOException isn't thrown #6788

Closed
pkanavos opened this issue Jun 2, 2021 · 2 comments · Fixed by #6809
Closed

Documented IOException isn't thrown #6788

pkanavos opened this issue Jun 2, 2021 · 2 comments · Fixed by #6809
Labels
area-System.IO doc-bug Problem with the content; needs to be fixed Pri3 Indicates issues/PRs that are low priority

Comments

@pkanavos
Copy link

pkanavos commented Jun 2, 2021 •
edited

In ZipFile.ExtractToDirectory and ZipFileExtensions.ExtractToDirectory the Exceptions section says that an IOException is thrown if the target directory exists. This is incorrect, as the method that is eventually called by these, the internal ExtractRelativeToDirectory, works fine with existing directories.

This was first asked in this SO question. I also opened an issue in the runtime repo

dotnet-api-docs/xml/System.IO.Compression/ZipFileExtensions.xml

Line 297 in 46c6267

<exception cref="T:System.IO.IOException">The directory specified by <paramref name="destinationDirectoryName" /> already exists.

@PRMerger19 PRMerger19 added the Pri3 Indicates issues/PRs that are low priority label Jun 2, 2021
@dotnet-bot dotnet-bot added the untriaged New issue has not been triaged by the area owner label Jun 2, 2021
@ghost
Copy link

ghost commented Jun 2, 2021

Tagging subscribers to this area: @carlossanlop
See info in area-owners.md if you want to be subscribed.

Issue Details

In ZipFile.ExtractToDirectory and ZipFileExtensions.ExtractToDirectory the Exceptions section says that an IOException is thrown if the target directory exists. This is incorrect, as the method that is eventually called by these, the internal ExtractRelativeToDirectory, works fine with existing directories.

This was first asked in this SO question

dotnet-api-docs/xml/System.IO.Compression/ZipFileExtensions.xml

Line 297 in 46c6267

<exception cref="T:System.IO.IOException">The directory specified by <paramref name="destinationDirectoryName" /> already exists.

Author: pkanavos
Assignees: -
Labels:

:watch: Not Triaged, Pri3, area-System.IO
Milestone: -

@pkanavos pkanavos mentioned this issue Jun 2, 2021
Closed
@gewarren gewarren mentioned this issue Jun 9, 2021
Merged
@mairaw mairaw added doc-bug Problem with the content; needs to be fixed and removed untriaged New issue has not been triaged by the area owner labels Jun 12, 2021
@Jozkee
Copy link
Member

Jozkee commented Jun 23, 2021

Closing as this needs to be fixed in source.
See dotnet/runtime#53609 (comment)

@Jozkee Jozkee closed this as completed Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-System.IO doc-bug Problem with the content; needs to be fixed Pri3 Indicates issues/PRs that are low priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove incorrect exception dotnet/dotnet-api-docs
5 participants
@pkanavos @dotnet-bot @mairaw @Jozkee @PRMerger19