Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrations: Improve functional test coverage #1141

Closed
rowanmiller opened this issue Nov 26, 2014 · 5 comments
Closed

Migrations: Improve functional test coverage #1141

rowanmiller opened this issue Nov 26, 2014 · 5 comments
Assignees
Labels
area-test closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Milestone

Comments

@rowanmiller
Copy link
Contributor

Probably by porting existing tests from EF6

@bricelam
Copy link
Contributor

bricelam commented Feb 8, 2015

Here are some scenarios I want to cover.

  • CSharpMigrationOperationGenerator can round-trip operations through the compiler
  • ModelDiffer can detect operations
    • ...and handle entity or property renames
    • ...and table or column renames
    • ...and sort correctly
  • MigrationSqlGenerator can apply operations to the database
  • Migrator can apply and revert migrations

@roji
Copy link
Member

roji commented Jul 7, 2015

Just wanted to know the state of migration functional tests before attacking migrations in PostgreSQL... There seem to be some non-inherited migration tests within each provider's testsuite but nothing comprehensive I can actually use. Should I wait a bit, are there plans to work on this?

@bricelam
Copy link
Contributor

bricelam commented Jul 7, 2015

@roji, So far, there are just unit tests to verify the SQL. You can copy these to use in your own unit tests. I also plan to create some provider-inheritable functional tests. I started in bricelam:migtests, but they were way too slow! We have some ideas on how to do it faster, but I haven't gotten around to implementing it yet.

@bricelam
Copy link
Contributor

I've added some basic functional tests that cover the HistoryRepository in #2733

@bricelam
Copy link
Contributor

Closing. I feel like our coverage is pretty decent now. We'll rely on app building, exploratory testing, and code coverage analysis for more. Creating more provider-agnostic tests will be done as part of #1807.

@bricelam bricelam modified the milestones: 7.0.0-beta7, 7.0.0 Aug 18, 2015
@ajcvickers ajcvickers added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Oct 15, 2022
@ajcvickers ajcvickers modified the milestones: 1.0.0-beta7, 1.0.0 Oct 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-test closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Projects
None yet
Development

No branches or pull requests

4 participants