Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make AsQueryable unnecessary for Include calls on collections #12238

Closed
divega opened this issue Jun 5, 2018 · 2 comments
Closed

Make AsQueryable unnecessary for Include calls on collections #12238

divega opened this issue Jun 5, 2018 · 2 comments
Labels
closed-out-of-scope This is not something that will be fixed/implemented and the issue is closed.

Comments

@divega
Copy link
Contributor

divega commented Jun 5, 2018

Lately we have discussed scenarios in which the Include method needs to be applied to a collection navigation inside the query’s projection. Because of the signature of Include, a call to AsQueryable has to be chained before Include in these scenarios. But unlike other query operators, Include is defined by EF Core, and we could choose to add versions work on IEnumerable<T>.

@ajcvickers
Copy link
Member

Notes from triage: Consider whether this pattern is something we want to promote going forward before doing this, especially in relation to reference navigations as well. See #12181 (comment) and #2953

@smitpatel
Copy link
Member

Irrelevant after #12737

@smitpatel smitpatel removed this from the Backlog milestone Oct 23, 2019
@ajcvickers ajcvickers added the closed-out-of-scope This is not something that will be fixed/implemented and the issue is closed. label Mar 10, 2022
@ajcvickers ajcvickers reopened this Oct 16, 2022
@ajcvickers ajcvickers closed this as not planned Won't fix, can't repro, duplicate, stale Oct 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-out-of-scope This is not something that will be fixed/implemented and the issue is closed.
Projects
None yet
Development

No branches or pull requests

3 participants