Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cosmos: Track owned entities when included with the owner #13579

Closed
AndriySvyryd opened this issue Oct 10, 2018 · 5 comments
Closed

Cosmos: Track owned entities when included with the owner #13579

AndriySvyryd opened this issue Oct 10, 2018 · 5 comments
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. punted-for-3.0 type-enhancement
Milestone
3.0.0

Comments

@AndriySvyryd
Copy link
Member

AndriySvyryd commented Oct 10, 2018 •
edited
Loading

Currently from context.Vehicles.First().Operator won't be tracked if Operator is an embedded owned entity. We should track both Vehicle and Operator.
@smitpatel smitpatel mentioned this issue Oct 10, 2018
Closed
82 tasks
@divega
Copy link
Contributor

divega commented Oct 11, 2018

@AndriySvyryd is this different form #13036?

@AndriySvyryd
Copy link
Member Author

@divega Yes, this is specifically about nested entities (stored in the same document). The implementation would have to be different.

@divega
Copy link
Contributor

divega commented Oct 11, 2018

@AndriySvyryd ok, thanks. I think the issues are joined at the hip though. We should apply whatever behavior we decide is best to both.

@ajcvickers ajcvickers added this to the Backlog milestone Oct 12, 2018
@ajcvickers ajcvickers modified the milestones: Backlog, 3.0.0 Oct 12, 2018
@AndriySvyryd AndriySvyryd mentioned this issue Nov 27, 2018
Closed
@smitpatel smitpatel removed this from the 3.0.0 milestone Dec 3, 2018
@divega divega added this to the 3.0.0 milestone Dec 7, 2018
@ajcvickers
Copy link
Member

ajcvickers commented Jan 24, 2019 •
edited
Loading

Do what we said in #13036

@ajcvickers ajcvickers changed the title Cosmos: Track owned entities from selectors Do #13036 for Cosmos Jan 24, 2019
@AndriySvyryd AndriySvyryd changed the title Do #13036 for Cosmos Cosmos: Track owned entities when included with the owner Jan 29, 2019
@ajcvickers
Copy link
Member

Putting this in backlog because #13036 covers what we need for 3.0.

@ajcvickers ajcvickers modified the milestones: 3.0.0, Backlog Jul 24, 2019
@AndriySvyryd AndriySvyryd modified the milestones: Backlog, 3.0.0-preview8 Jul 29, 2019
@AndriySvyryd AndriySvyryd added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Jul 29, 2019
@AndriySvyryd AndriySvyryd mentioned this issue Jul 29, 2019
Merged
@smitpatel smitpatel mentioned this issue Aug 5, 2019
Closed
@ajcvickers ajcvickers modified the milestones: 3.0.0-preview8, 3.0.0 Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. punted-for-3.0 type-enhancement
Projects
None yet
Milestone
3.0.0
Development

No branches or pull requests
4 participants
@divega @ajcvickers @smitpatel @AndriySvyryd