Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query: Add query tags to warnings/exceptions #15127

Open
ajcvickers opened this issue Mar 22, 2019 · 1 comment
Open

Query: Add query tags to warnings/exceptions #15127

ajcvickers opened this issue Mar 22, 2019 · 1 comment
Labels
area-query good first issue This issue should be relatively straightforward to fix. punted-for-3.0 type-enhancement
Milestone
Backlog

Comments

@ajcvickers
Copy link
Member

Note: this issue is NOT about automatically creating query tags. See #14134 (comment)

If a query tag has been defined, then it would be useful for that tag to be included in the exception message or warning message when related to that query. See #15101
@ajcvickers ajcvickers mentioned this issue Mar 22, 2019
Closed
@ajcvickers ajcvickers added this to the 3.0.0 milestone Mar 23, 2019
@jzabroski
Copy link

@ajcvickers Automatically creating query tags is trivial. Why do you think its hard? It's just encapsulating DbSet<T>().AddComment(string) builder pattern via an interceptor, instead of directly injecting DbSet<T>

What am I missing about complexity?

@ajcvickers ajcvickers modified the milestones: 3.0.0, Backlog May 10, 2019
@ajcvickers ajcvickers added the good first issue This issue should be relatively straightforward to fix. label Sep 2, 2019
@AndriySvyryd AndriySvyryd mentioned this issue May 18, 2021
Closed
@smitpatel smitpatel changed the title Automatically add query tags to warnings/exceptions Query: Add query tags to warnings/exceptions May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-query good first issue This issue should be relatively straightforward to fix. punted-for-3.0 type-enhancement
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
4 participants
@jzabroski @ajcvickers @smitpatel @maumar