Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query cache (eviction) changes between 2.2.6 and 3.0 (preview 8) #17384

Closed
mvacha opened this issue Aug 22, 2019 · 3 comments
Closed

Query cache (eviction) changes between 2.2.6 and 3.0 (preview 8) #17384

mvacha opened this issue Aug 22, 2019 · 3 comments
Labels
closed-no-further-action The issue is closed and no further action is planned. customer-reported

Comments

@mvacha
Copy link

mvacha commented Aug 22, 2019

We are investigating a memory leak in our app, that occurs with EF 2.2.6, but no longer happens in 3.0-preview 8. It seems similar to #13513, but I haven't been able to find any merge request that would be fixing this issue, or a PR implementing cache eviction that had been merged to 3.0 (e.g. some follow-up PR of #13021).

Have there been any changes in how caching of queries work in 3.0 (or updates on: #12905)? Thanks.

@ajcvickers
Copy link
Member

@mvacha The internals of the query pipeline have been extensively changed for the 3.0 release. As part of this several bugs in query/compilation caching have been fixed, although it is hard to isolate these to specific PRs. That being said, nothing has explicitly changed in cache eviction itself. Given that you are no longer seeing the memory leak it seems likely that the architecture change fixed the issue you are seeing on 2.2, so closing this for now.

@ajcvickers ajcvickers added the closed-no-further-action The issue is closed and no further action is planned. label Aug 26, 2019
@mvacha
Copy link
Author

mvacha commented Aug 30, 2019

@ajcvickers Thank you for your response. We mitigated the issue in 2.2.6. by using parameterized queries and splitting large EF queries into multiple ones. Since it is fixed in 3.0, I assume it does not make sense for us to investigate what particularly caused it as 2.2. won't be receiving any updates except critical bug fixes in the future, am I right?

@ajcvickers
Copy link
Member

@mvacha That's correct.

@ajcvickers ajcvickers reopened this Oct 16, 2022
@ajcvickers ajcvickers closed this as not planned Won't fix, can't repro, duplicate, stale Oct 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-no-further-action The issue is closed and no further action is planned. customer-reported
Projects
None yet
Development

No branches or pull requests

2 participants