Translate to IN + subquery when possible instead of EXISTS #30976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roji
commented
May 26, 2023
| // Null out the value for the inferred type mapping as an indication of the conflict. If it turns out that we need the | ||
| // inferred mapping later, during the application phase, we'll throw an exception at that point (not all the inferred type | ||
| // mappings here will actually be needed, so we don't want to needlessly throw here). | ||
| _inferredColumns[(underlyingTable, columnExpression.Name)] = null; |
There was a problem hiding this comment.
I moved the "conflicting inferred type mappings" exception to later in the process, so that we don't throw if we don't actually need the inferred mapping (i.e. it doesn't apply to an untyped inline/parameter collection). This should be safer.
src/EFCore.Relational/Query/RelationalSqlTranslatingExpressionVisitor.cs
Show resolved
Hide resolved
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Given the pretty massive perf impact this has (see #30955 (comment)), converting to a draft to consider using IN in more scenarios instead of rewriting to EXISTS (but this can still be reviewed already). |
maumar
reviewed
May 31, 2023
test/EFCore.SqlServer.FunctionalTests/Query/ComplexNavigationsQuerySqlServerTest.cs
Show resolved
Hide resolved
maumar
reviewed
May 31, 2023
maumar
reviewed
Jun 1, 2023
test/EFCore.SqlServer.FunctionalTests/Query/ComplexNavigationsSharedTypeQuerySqlServerTest.cs
Show resolved
Hide resolved
maumar
reviewed
Jun 1, 2023
src/EFCore.Relational/Query/RelationalQueryableMethodTranslatingExpressionVisitor.cs
Outdated
Show resolved
Hide resolved
maumar
reviewed
Jun 1, 2023
src/EFCore.Relational/Query/RelationalSqlTranslatingExpressionVisitor.cs
Outdated
Show resolved
Hide resolved
maumar
approved these changes
Jun 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on top of #30956 (ignore first commit)to translate to IN+subquery where possible (see #30955).Closes #30955