Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompositeEntityKeyFactory always reads values as "object" #736

Closed
ajcvickers opened this issue Oct 1, 2014 · 2 comments
Closed

CompositeEntityKeyFactory always reads values as "object" #736

ajcvickers opened this issue Oct 1, 2014 · 2 comments
Labels

Comments

@ajcvickers
Copy link
Member

SimpleEntityKeyFactory objects are created dynamically and are generic on the type of the key property such that the ReadValue method uses the correct type of the key property. This avoids some boxing and also means that, when used with a DataReader, will call the typed reader method. We know that using the typed reader method can be important for some ADO.NET providers that do dynamic conversion based on the expected type.

CompositeEntityKeyFactory objects currently do none of this and just use ReadValue.

@rowanmiller
Copy link
Contributor

SQL Server works at the moment, we'll need to come back to this when we bring SQLite back in.

@ajcvickers
Copy link
Member Author

This code has all changed. Issue is no longer relevant.

@ajcvickers ajcvickers removed this from the Backlog milestone Jul 8, 2016
@ajcvickers ajcvickers reopened this Oct 16, 2022
@ajcvickers ajcvickers closed this as not planned Won't fix, can't repro, duplicate, stale Oct 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants