Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove temp code for culture flowing across async calls #862

Closed
AndriySvyryd opened this issue Oct 13, 2014 · 1 comment
Closed

Remove temp code for culture flowing across async calls #862

AndriySvyryd opened this issue Oct 13, 2014 · 1 comment
Assignees
@bricelam
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-unknown
Milestone
1.0.0

Comments

@AndriySvyryd
Copy link
Member

This issue only affects users running on desktop .Net without Project K. The fix uses the Thread class which is currently not available on the portable target. Thus we need to build for .Net 4.5 for the fix to work.

We should either make this work on portable when the API is available or to revert the fix altogether since this is a fairly minor problem that is only present on older platforms.
@AndriySvyryd AndriySvyryd self-assigned this Oct 13, 2014
@divega
Copy link
Contributor

divega commented Oct 13, 2014

I heard there are plans to make CultureInfo.Current[UI]Culture async local. We may be able to get rid of the workaround.

@rowanmiller rowanmiller modified the milestones: 1.0.0, 1.0.0-rc1 Oct 22, 2014
@rowanmiller rowanmiller modified the milestones: 7.0.0-rc1, 7.0.0 Nov 25, 2014
@rowanmiller rowanmiller changed the title Review the fix for culture flowing across async calls Remove temp code for culture flowing across async calls Dec 12, 2014
@rowanmiller rowanmiller added task and removed pri0 labels Dec 12, 2014
@bricelam bricelam assigned bricelam and unassigned AndriySvyryd May 1, 2015
@bricelam bricelam modified the milestones: 7.0.0-beta5, 7.0.0 May 1, 2015
@ajcvickers ajcvickers added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Oct 15, 2022
@ajcvickers ajcvickers modified the milestones: 1.0.0-beta5, 1.0.0 Oct 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bricelam bricelam

Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-unknown
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
5 participants
@bricelam @divega @ajcvickers @rowanmiller @AndriySvyryd