Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in IDE checking using VIsualFSharp.sln on main #11176

Closed
dsyme opened this issue Mar 3, 2021 · 3 comments · Fixed by #11177
Closed

Bug in IDE checking using VIsualFSharp.sln on main #11176

dsyme opened this issue Mar 3, 2021 · 3 comments · Fixed by #11177
Labels
Bug Impact-High (Internal MS Team use only) Describes an issue with extreme impact on existing code. Regression

Comments

@dsyme
Copy link
Contributor

dsyme commented Mar 3, 2021

"main" has a bug where opening VIsualFSharp.sln (after installing into RoslynDev ) reveals an error:

image

There are many other errors later in the solution as well, e.g. here in range.fs

image

It's a very strange problem, I will try to determine the source of the issue now.

Repro

  1. Build "main"

    .\build -c Release -deploy
    
  2. Open VisualFSharp.sln

    devenv VisualFSharp.sln /RootSuffix RoslynDev
    
  3. Open "lib.fs" and "range.fs" and see if the above errors occur (they shouldn't)

@dsyme
Copy link
Contributor Author

dsyme commented Mar 3, 2021

I'm going to do a binary chop on the commit history to determine where this bug crept in

Starting with 178ec2f as a random point in time

@cartermp cartermp added the Bug label Mar 3, 2021
@auduchinok
Copy link
Member

auduchinok commented Mar 3, 2021

@dsyme This is what I see in Rider with an FCS build based on 718d3c4:
Screenshot 2021-03-03 at 18 44 03

@dsyme
Copy link
Contributor Author

dsyme commented Mar 3, 2021

Binary chop

Since 612c65d is just a README change this means my cleanup PR #11151 is responsible. I'll look for the problem

https://github.com/dotnet/fsharp/pull/11151/files?diff=unified&w=1#diff-4cf589945def81188bed84b5466d6c2c6eca933e91427e54ed059f018fb9cec9L120 looks suspicious. EmptyParsedInput will fill in a different value for this field.

@dsyme dsyme added Regression Impact-High (Internal MS Team use only) Describes an issue with extreme impact on existing code. labels Mar 3, 2021
@dsyme dsyme closed this as completed Mar 3, 2021
@dsyme dsyme reopened this Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Impact-High (Internal MS Team use only) Describes an issue with extreme impact on existing code. Regression
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants