Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove quick fix for adding _ when using a union case with not data #14066

Closed
Tracked by #15408
edgarfgp opened this issue Oct 10, 2022 · 3 comments
Closed
Tracked by #15408

Remove quick fix for adding _ when using a union case with not data #14066

edgarfgp opened this issue Oct 10, 2022 · 3 comments
Assignees
@T-Gro
Labels
Area-LangService-CodeFixes Code fixes associated with diagnostics good first issue help wanted Impact-Low (Internal MS Team use only) Describes an issue with limited impact on existing code. Theme-Simple-F# A cross-community initiative called "Simple F#", keeping people in the sweet spot of the language.
Milestone
November-2022

Comments

@edgarfgp
Copy link
Contributor

Now that #14055 is merged and based on @vzarytovskii comment #14055 (comment).

We should remove the existing quick fix for adding _ See the image

image

We should instead reuse the existing quick fix to remove the wildcard .
@T-Gro T-Gro self-assigned this Oct 10, 2022
@T-Gro T-Gro added good first issue Impact-Low (Internal MS Team use only) Describes an issue with limited impact on existing code. Theme-Simple-F# A cross-community initiative called "Simple F#", keeping people in the sweet spot of the language. Area-LangService-CodeFixes Code fixes associated with diagnostics help wanted and removed Bug Needs-Triage labels Oct 11, 2022
@edgarfgp
Copy link
Contributor Author

edgarfgp commented Oct 12, 2022 •
edited

@auduchinok should I raise a similar issue in Rider to have to consistency across editors ?

cc @baronfel

@auduchinok
Copy link
Member

@auduchinok should I raise a similar issue in Rider to have to consistency across editors ?

Yes, please do. I'll see if what we'd need to update on our side. 🙂

@vzarytovskii vzarytovskii added this to the Backlog milestone Oct 17, 2022
@T-Gro T-Gro modified the milestones: Backlog, November-2022 Nov 2, 2022
@T-Gro
Copy link
Member

T-Gro commented Nov 11, 2022

Solved by #14267

@T-Gro T-Gro closed this as completed Nov 11, 2022
@psfinaki psfinaki mentioned this issue Jun 15, 2023
Open
85 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@T-Gro T-Gro

Labels
Area-LangService-CodeFixes Code fixes associated with diagnostics good first issue help wanted Impact-Low (Internal MS Team use only) Describes an issue with limited impact on existing code. Theme-Simple-F# A cross-community initiative called "Simple F#", keeping people in the sweet spot of the language.
Projects
F# Compiler and Tooling
Archived in project
Milestone
November-2022
Development

When branches are created from issues, their pull requests are automatically linked.

14066-remove-quick-fix-for-adding-_-when-using-a-union-case-with-not-data T-Gro/fsharp
4 participants
@vzarytovskii @auduchinok @edgarfgp @T-Gro