Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken behavior of the RemoveUnusedBinding code fix #15411

Closed
Tracked by #15408
psfinaki opened this issue Jun 15, 2023 · 0 comments · Fixed by #15663
Closed
Tracked by #15408

Broken behavior of the RemoveUnusedBinding code fix #15411

psfinaki opened this issue Jun 15, 2023 · 0 comments · Fixed by #15663
Labels
Area-LangService-CodeFixes Code fixes associated with diagnostics Bug good first issue Impact-Medium (Internal MS Team use only) Describes an issue with moderate impact on existing code.
Milestone
Backlog

Comments

@psfinaki
Copy link
Member

Code:

type DU =
    | X
    | Y

    member t.A = 42

The respective code fix does something weird:

bug.mp4
@psfinaki psfinaki added Bug Area-LangService-CodeFixes Code fixes associated with diagnostics Needs-Triage labels Jun 15, 2023
@github-actions github-actions bot added this to the Backlog milestone Jun 15, 2023
@psfinaki psfinaki mentioned this issue Jun 15, 2023
Open
85 tasks
@0101 0101 added Impact-Medium (Internal MS Team use only) Describes an issue with moderate impact on existing code. and removed Needs-Triage labels Jun 19, 2023
This was referenced Jul 19, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-LangService-CodeFixes Code fixes associated with diagnostics Bug good first issue Impact-Medium (Internal MS Team use only) Describes an issue with moderate impact on existing code.
Projects
F# Compiler and Tooling
Archived in project
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Fixing code fixes, part 5 psfinaki/fsharp
2 participants
@0101 @psfinaki