Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProposeUpperCaseLabel code fix doesn't work for unsaved files #15500

Closed
Tracked by #15408
psfinaki opened this issue Jun 27, 2023 · 2 comments · Fixed by #15508
Closed
Tracked by #15408

ProposeUpperCaseLabel code fix doesn't work for unsaved files #15500

psfinaki opened this issue Jun 27, 2023 · 2 comments · Fixed by #15508
Milestone

Comments

@psfinaki
Copy link
Member

Repro:

bug.mp4

So yeah - once the file is saved the fix becomes applicable. This shouldn't be the case, this is not how the code fixes are supposed to work. Example:

example.mp4
@github-actions github-actions bot added this to the Backlog milestone Jun 27, 2023
@psfinaki psfinaki added Area-LangService-CodeFixes Code fixes associated with diagnostics good first issue labels Jun 27, 2023
@psfinaki psfinaki mentioned this issue Jun 27, 2023
85 tasks
@vzarytovskii
Copy link
Member

Not really a bug, it's not supposed to work, iirc. It's more of the improvement.

@psfinaki
Copy link
Member Author

psfinaki commented Jun 27, 2023

Yeah depends on how you look on it. Other code fixes work like this and, well, VS does offer the code fix for the unsaved document to the end user and then "nothing happens". So at least it looks like a bug :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants