Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with .NET 5.0 #274

Closed
5 of 6 tasks
kant2002 opened this issue Aug 25, 2020 · 5 comments
Closed
5 of 6 tasks

Issues with .NET 5.0 #274

kant2002 opened this issue Aug 25, 2020 · 5 comments

Comments

@kant2002
Copy link
Contributor

kant2002 commented Aug 25, 2020

I attempt to re-target solution to .NET 5.0 and found couple issues

@kant2002
Copy link
Contributor Author

@tminka I can take a look at these problems myself, but BinaryFormatter usage indicates on possible internal testing process which I cannot guess how to replace. Do you interested in me pursuing these changes?

@tminka
Copy link
Contributor

tminka commented Aug 25, 2020

There is no need to use BinaryFormatter there. It is only storing the results of one test to be used in another test. Also, those tests are developer tests, not unit tests. You can comment out the offending lines and leave a TODO to have them fixed later. Thanks.

@kant2002
Copy link
Contributor Author

@tminka I think I made necessary change for BinaryFormatter.

@kant2002
Copy link
Contributor Author

kant2002 commented Sep 1, 2020

Except first one item in the list everything is done. and #273 can be looked at.

@kant2002 kant2002 closed this as completed Sep 1, 2020
@YnnamTenob
Copy link

YnnamTenob commented Oct 18, 2021

@tminka I added this issue regarding Binary Serialization - Binary Formatter. I see the code change @kant2002 made w.r.t. to that test but is there a solution for actually serializing in the .Net 5.0 environment. for example with incremental learning models?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants