Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linker should warn if it can't figure out DynamicallyAccessedMembersAttribute on a property #1248

Closed
vitek-karas opened this issue Jun 5, 2020 · 2 comments
Closed

Linker should warn if it can't figure out DynamicallyAccessedMembersAttribute on a property #1248

vitek-karas opened this issue Jun 5, 2020 · 2 comments
Assignees
@vitek-karas
Labels
area-Linker: DataFlow
Projects
.NET 5 Tasks Prioritization
Milestone
.NET 5.0

Comments

@vitek-karas
Copy link
Member

There are TODOs in the code to make this happen, but we didn't. Since this can lead to rather unexpected behaviors (and puzzling for the user) we should really issue warnings for these cases.
@vitek-karas vitek-karas added this to the .NET5.0 milestone Jun 5, 2020
@vitek-karas vitek-karas mentioned this issue Jun 5, 2020
Merged
@vitek-karas vitek-karas added this to High priority in .NET 5 Tasks Prioritization Jun 5, 2020
@vitek-karas
Copy link
Member Author

First part of the fix is in #1255. The remaining work requires annotation propagation over virtual method overrides.

@vitek-karas vitek-karas self-assigned this Jun 9, 2020
@vitek-karas
Copy link
Member Author

This is now completed with the virtual method hierarchies validations in place.

.NET 5 Tasks Prioritization automation moved this from High priority to Completed Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vitek-karas vitek-karas

Labels
area-Linker: DataFlow
Projects
No open projects
.NET 5 Tasks Prioritization
Completed
Milestone
.NET 5.0
Development

No branches or pull requests
1 participant
@vitek-karas