We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I would suggest to create const MaxId private const long MaxId = 262111; and use it across whole file https://github.com/dotnet/machinelearning-samples/blob/master/samples/csharp/getting-started/MatrixFactorization_ProductRecommendation/ProductRecommender/Program.cs and add comment what it should be (maximum id value in file +1). Any Id which is above or equal to that value would be ignored. Otherwise users will just bring their dataset and would be upset that it doesn't work like here: dotnet/machinelearning#2488
private const long MaxId = 262111;
The text was updated successfully, but these errors were encountered:
As dotnet/machinelearning#2488 had been fixed, may we close this issue?
Sorry, something went wrong.
Sure @wschin
No branches or pull requests
I would suggest to create const MaxId
private const long MaxId = 262111;
and use it across whole file https://github.com/dotnet/machinelearning-samples/blob/master/samples/csharp/getting-started/MatrixFactorization_ProductRecommendation/ProductRecommender/Program.cs and add comment what it should be (maximum id value in file +1).
Any Id which is above or equal to that value would be ignored.
Otherwise users will just bring their dataset and would be upset that it doesn't work like here: dotnet/machinelearning#2488
The text was updated successfully, but these errors were encountered: