Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Product recommendation sample #249

Closed
Ivanidzo4ka opened this issue Feb 12, 2019 · 2 comments
Closed

Product recommendation sample #249

Ivanidzo4ka opened this issue Feb 12, 2019 · 2 comments
Labels
enhancement New feature or request

Comments

@Ivanidzo4ka
Copy link

I would suggest to create const MaxId
private const long MaxId = 262111;
and use it across whole file https://github.com/dotnet/machinelearning-samples/blob/master/samples/csharp/getting-started/MatrixFactorization_ProductRecommendation/ProductRecommender/Program.cs and add comment what it should be (maximum id value in file +1).
Any Id which is above or equal to that value would be ignored.
Otherwise users will just bring their dataset and would be upset that it doesn't work like here: dotnet/machinelearning#2488

@CESARDELATORRE CESARDELATORRE added the enhancement New feature or request label Mar 5, 2019
@wschin
Copy link
Member

wschin commented Mar 29, 2019

As dotnet/machinelearning#2488 had been fixed, may we close this issue?

@prathyusha12345
Copy link
Contributor

Sure @wschin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants