Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LightGBM Random Forest #1992

Closed
Tracked by #6337
justinormont opened this issue Jan 1, 2019 · 3 comments
Closed
Tracked by #6337

LightGBM Random Forest #1992

justinormont opened this issue Jan 1, 2019 · 3 comments
Labels
enhancement New feature or request P2 Priority of the issue for triage purpose: Needs to be fixed at some point.

Comments

@justinormont
Copy link
Contributor

justinormont commented Jan 1, 2019

LightGBM added random forest support in July 2017. ML.NET should expose this functionality.

This is exposed as another booster type. Currently we support { Tree Booster, Dropout Tree Booster, and Gradient-based One-Size Sampling } (src) boosters of LightGBM.

For our defaults for the new booster type we could copy the test:
https://github.com/Microsoft/LightGBM/blob/fb28070e1daa500b087d3102145ae48988030195/tests/python_package_test/test_engine.py#L53-L62

I don't see that LightGBM provides a default for these parameters. So we need to provide reasonable defaults for the user; without ff/bagfrac set to <1.0, LightGBM throws an error. I think ff=0.5 & bagfrac=0.5 may be a bit low; perhaps 0.7? As always benchmarks on representative datasets speak louder than I.

This adds to our existing FastTree Random Forest implementation, and is another implementation that could be use for #1729.

@justinormont justinormont added the enhancement New feature or request label Jan 1, 2019
@yaeldekel
Copy link

Hi @justinormont , thanks for the suggestion! I am not sure if we can add new features before 1.0, but we should definitely triage this.

@yaeldekel yaeldekel assigned yaeldekel and unassigned yaeldekel Jan 4, 2019
@Ivanidzo4ka
Copy link
Contributor

I notice some work by @singlis regarding LightGBM and bringing monotonic support. Do you have time to look on random forest support?

@singlis singlis added this to To Do in Backlog via automation Mar 29, 2019
@wschin wschin added the P1 Priority of the issue for triage purpose: Needs to be fixed soon. label May 21, 2019
@harishsk harishsk added P2 Priority of the issue for triage purpose: Needs to be fixed at some point. and removed P1 Priority of the issue for triage purpose: Needs to be fixed soon. labels Jan 10, 2020
@luisquintanilla
Copy link
Contributor

Closing for now, in the meantime, you might be able to import a RF model into ML.NET and inference that way.

@github-actions github-actions bot locked and limited conversation to collaborators Jan 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request P2 Priority of the issue for triage purpose: Needs to be fixed at some point.
Projects
Backlog
  
To Do
v0.11
  
Awaiting triage
Development

No branches or pull requests

6 participants