Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to rename HalLearners assembly and nuget #2756

Closed
eerhardt opened this issue Feb 27, 2019 · 4 comments · Fixed by #2800
Closed

Need to rename HalLearners assembly and nuget #2756

eerhardt opened this issue Feb 27, 2019 · 4 comments · Fixed by #2800
Assignees
Milestone

Comments

@eerhardt
Copy link
Member

The name HalLearners isn't a great public name. We should come up with a better name.

Current issues:

  1. What does Hal mean?
  2. We are using the term "trainers" instead of "learners" everywhere else.
  3. This assembly contains more than just learners/trainers. It also has vector whitening, which isn't a trainer.

Possible suggestions to get the naming started:

  1. Microsoft.ML.HardwareAccelerated
  2. Microsoft.ML.HardwareAccelerated.Components
  3. Microsoft.ML.Mkl
    • (we already have Microsoft.ML.Mkl.Redist. this would be an analog to ML.TensorFlow and ML.TensorFlow.Redist)
  4. Microsoft.ML.Mkl.Components

@TomFinley @sfilipi @Ivanidzo4ka @shauheen @yaeldekel

@eerhardt eerhardt added this to To do in Project 13 via automation Feb 27, 2019
@TomFinley
Copy link
Contributor

TomFinley commented Feb 27, 2019

I think it was a joke to refer to those learners that had this relatively heavyweight MKL library as a dependency for one reason or another.

I like Microsoft.ML.MklTrainers or Microsoft.ML.MklComponents or Microsoft.ML.Mkl or something like this. (If possible Trainers would be good, but there's more in there that depends on MKL than merely trainer estimators -- so maybe the more general name would be good).

"Hardware accelerated" is far too prone to misunderstanding in my opinion. Without knowing what I know, I think if I were to look at this library, and I saw, "hardware accelerated," my natural thought would be "OK, so, they are saying the rest the stuff isn't hardware accelerated." And, that would be incorrect while also making us look kind of silly.

@codemzs codemzs self-assigned this Feb 27, 2019
@codemzs
Copy link
Member

codemzs commented Feb 27, 2019

Even Microsoft.ML.MKLTrainers is a bit controversial because TimeSeries for example uses MKL but is not in this nuget.

@TomFinley
Copy link
Contributor

I see. Well, I'm not sure that's a blocker. We have after all the "transforms" assembly without the suggestion that it refers to all transforms. (Indeed it does not.) How about Microsoft.ML.Mkl.Components then, anyway?

@codemzs
Copy link
Member

codemzs commented Feb 28, 2019

Microsoft.ML.Mkl.Components it is! :)

@eerhardt eerhardt moved this from To do to In progress in Project 13 Mar 1, 2019
Project 13 automation moved this from In progress to Done Mar 3, 2019
@shauheen shauheen added this to the 0319 milestone Mar 4, 2019
@shauheen shauheen added this to Done in v0.12 Mar 4, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Mar 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
No open projects
Project 13
  
Done
v0.12
  
Done
Development

Successfully merging a pull request may close this issue.

4 participants