[Android] Fix Map not setting initial properties #10739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsuarezruiz
commented
Oct 17, 2022
| map.MarkerClick += OnMarkerClick; | ||
| map.InfoWindowClick += OnInfoWindowClick; | ||
| map.MapClick += OnMapClick; | ||
|
|
||
| if (VirtualView != null) |
There was a problem hiding this comment.
This is the main change. The mapper invoke the mapping methods to update basic properties, but in the case of the zoom for example, the map is not initialized yet and nothing is done. For that reason, we apply changes to set the basic properties when having the map ready.
jsuarezruiz
commented
Oct 17, 2022
| MapType.Hybrid => GoogleMap.MapTypeHybrid, | ||
| _ => throw new ArgumentOutOfRangeException(), | ||
| }; | ||
| googleMap?.UpdateMapType(map); |
There was a problem hiding this comment.
Moved to extension methods. On the one hand, we achieve homogeneity with other handlers code but in the other hand it is also necessary to invoke some properties update when the map is ready.
rmarinho
approved these changes
Oct 17, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fix Map not setting initial properties.
Issues Fixed
Fixes #10394