Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Shell TabBar overlaps ContentPage when calling Shell.SetTabBarIsVisible(this, true) #10591

Open
ewerspej opened this issue Oct 10, 2022 · 2 comments
Labels
area-controls-shell Shell Navigation, Routes, Tabs, Flyout platform/iOS 🍎 s/triaged Issue has been reviewed s/verified Verified / Reproducible Issue ready for Engineering Triage t/bug Something isn't working
Milestone

Comments

@ewerspej
Copy link

ewerspej commented Oct 10, 2022

Description

On iOS the Shell TabBar cuts off the bottom of a ContentPage when manually setting Shell.SetTabBarIsVisible(BindableObject obj, bool visible) or when binding Shell.TabBarIsVisible to a property.

It seems like there is a layout update missing when calling Shell.SetTabBarIsVisible(this, true);, because bottom items disappear behind the TabBar and centered elements appear lower afterwards. This indicates that the ContentPage extends behind the TabBar instead of being correctly recalculated.

Steps to Reproduce

  1. Create a new MAUI app
  2. Add a TabBar in the Shell with two Tabs incl. ShellContent
  3. Add a Grid to the MainPage with a Label centered vertically and a Button (or any other View element) at the bottom (or fairly close to the bottom)
  4. Override OnSizeAllocated(double width, double height) of MainPage and call Shell.SetTabBarIsVisible(this, height > width);
  5. Run on a real iOS device
  6. Rotate from Portrait into Landscape
  7. Rotate from Landscape back into Portrait

Expected result: The TabBar is correctly shown and hidden and the ContentPage is always rendered correctly
Actual result: The TabBar hides the bottom of the ContentPage after calling Shell.SetTabBarIsVisible(this, height > width);

Link to public reproduction project repository

https://github.com/ewerspej/dotnet-maui-bug-tabbar-ios-cutoff/

Version with bug

7.0.0-rc.1.22426.10

Last version that worked well

Unknown/Other

Affected platforms

iOS

Affected platform versions

iOS 15.5

Did you find any workaround?

No

Relevant log output

No response

@ewerspej ewerspej added the t/bug Something isn't working label Oct 10, 2022
@jsuarezruiz jsuarezruiz added platform/iOS 🍎 area-controls-shell Shell Navigation, Routes, Tabs, Flyout labels Oct 11, 2022
@PureWeen PureWeen added this to the Backlog milestone Oct 11, 2022
@ghost
Copy link

ghost commented Oct 11, 2022

We've moved this issue to the Backlog milestone. This means that it is not going to be worked on for the coming release. We will reassess the backlog following the current release and consider this item at that time. To learn more about our issue management process and to have better expectation regarding different types of issues you can read our Triage Process.

@jinxinjuan jinxinjuan added s/verified Verified / Reproducible Issue ready for Engineering Triage s/triaged Issue has been reviewed labels Jul 7, 2023
@jinxinjuan
Copy link
Collaborator

Verified this issue with Visual Studio Enterprise 17.7.0 Preview 2.0. Can repro on iOS platform with sample project. dotnet-maui-bug-tabbar-ios-cutoff/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-controls-shell Shell Navigation, Routes, Tabs, Flyout platform/iOS 🍎 s/triaged Issue has been reviewed s/verified Verified / Reproducible Issue ready for Engineering Triage t/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants