Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] A big image overflow the Button #12054

Closed
jsuarezruiz opened this issue Dec 13, 2022 · 4 comments
Closed

[Android] A big image overflow the Button #12054

jsuarezruiz opened this issue Dec 13, 2022 · 4 comments
Assignees
Labels
area-controls-button Button, ImageButton platform/android 🤖 s/triaged Issue has been reviewed s/verified Verified / Reproducible Issue ready for Engineering Triage scenario-day t/bug Something isn't working
Milestone

Comments

@jsuarezruiz
Copy link
Contributor

Description

A big image is not resized or adapted and can overflow the Button.

image

<Button
    HeightRequest="60"
    ImageSource="dotnet_bot.png"
    Text="Default" />
<Button
    HeightRequest="60"
    ImageSource="dotnet_bot.png"
    Text="Left - 10"
    ContentLayout="Left, 10" />
<Button
    HeightRequest="60"
    ImageSource="dotnet_bot.png"
    Text="Top - 10"
    ContentLayout="Top, 10" />

Steps to Reproduce

  1. Download or sync https://github.com/jsuarezruiz/dotnet-maui-testing-playground
  2. Launch the App and navigate to the Button test cases.
  3. The B9 test case validating the ContentLayout and ImageSource properties is failing.

Link to public reproduction project repository

https://github.com/jsuarezruiz/dotnet-maui-testing-playground

Version with bug

7.0 (current)

Last version that worked well

Unknown/Other

Affected platforms

Android

Affected platform versions

Android 13

Did you find any workaround?

No response

Relevant log output

No response

@jsuarezruiz jsuarezruiz added t/bug Something isn't working platform/android 🤖 area-controls-button Button, ImageButton labels Dec 13, 2022
@ghost ghost added the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label Dec 13, 2022
@mattleibow mattleibow added this to the Backlog milestone Dec 13, 2022
@ghost
Copy link

ghost commented Dec 13, 2022

We've moved this issue to the Backlog milestone. This means that it is not going to be worked on for the coming release. We will reassess the backlog following the current release and consider this item at that time. To learn more about our issue management process and to have better expectation regarding different types of issues you can read our Triage Process.

@jinxinjuan jinxinjuan added s/triaged Issue has been reviewed s/verified Verified / Reproducible Issue ready for Engineering Triage labels Jun 2, 2023
@jinxinjuan
Copy link
Collaborator

Verified this issue with Visual Studio 17.7.0 Preview 1.0. Can repro on android platform with sample project.
dotnet-maui-testing-playground

@jsuarezruiz
Copy link
Contributor Author

The issue will be fixed by https://github.com/dotnet/maui/tree/fix-12054

@PureWeen
Copy link
Member

Currently

image

After @mattleibow 's PR for SR4

image

@github-actions github-actions bot locked and limited conversation to collaborators Apr 18, 2024
@Eilon Eilon removed the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label May 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-controls-button Button, ImageButton platform/android 🤖 s/triaged Issue has been reviewed s/verified Verified / Reproducible Issue ready for Engineering Triage scenario-day t/bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

6 participants