Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hot Reload does not work or stops working in some specific cases #13052

Closed
jsuarezruiz opened this issue Feb 1, 2023 · 12 comments
Closed

Hot Reload does not work or stops working in some specific cases #13052

jsuarezruiz opened this issue Feb 1, 2023 · 12 comments
Assignees
Labels
area-tooling XAML & C# Hot Reload, XAML Editor, Live Visual Tree, Live Preview, Debugging partner/hot-reload-xaml Issues impacting XAML Hot Reload experiences platform/android 🤖 platform/windows 🪟 s/triaged Issue has been reviewed s/try-latest-version Please try to reproduce the potential issue on the latest public version t/bug Something isn't working
Milestone

Comments

@jsuarezruiz
Copy link
Contributor

jsuarezruiz commented Feb 1, 2023

Description

I have noticed that updating VisualStates from a style https://github.com/jsuarezruiz/netmaui-movies-app-challenge/blob/main/src/MoviesApp/Views/MoviesView.xaml#L19, especially complex elements such as CarouselView or Border, stops XAML Hot Reload from working.

issue-hr

Updating VisualStates (without styles) does not update the changes. https://github.com/jsuarezruiz/netmaui-movies-app-challenge/blob/main/src/MoviesApp/Views/MoviesView.xaml#L146

Steps to Reproduce

  1. Download or sync https://github.com/jsuarezruiz/netmaui-movies-app-challenge
  2. Launch the App on an Android emulator.
  3. Try to update the shared lines from VisualStates.

Link to public reproduction project repository

https://github.com/jsuarezruiz/netmaui-movies-app-challenge

Version with bug

7.0 (current)

Last version that worked well

Unknown/Other

Affected platforms

Android, Windows

Affected platform versions

Android 13

Did you find any workaround?

No response

Relevant log output

No response

VS bug #1748371

@jsuarezruiz jsuarezruiz added t/bug Something isn't working area-tooling XAML & C# Hot Reload, XAML Editor, Live Visual Tree, Live Preview, Debugging partner/hot-reload-xaml Issues impacting XAML Hot Reload experiences labels Feb 1, 2023
@jsuarezruiz jsuarezruiz added the s/move-to-vs-feedback Tells automation to ask the person to use VS Feedback to report the issue label Feb 2, 2023
@ghost
Copy link

ghost commented Feb 2, 2023

Thanks for the issue report @jsuarezruiz! This issue appears to be a problem with Visual Studio, so we ask that you use the VS feedback tool to report the issue. That way it will get to the routed to the team that owns this experience in VS.

If you encounter a problem with Visual Studio, we want to know about it so that we can diagnose and fix it. By using the Report a Problem tool, you can collect detailed information about the problem, and send it to Microsoft with just a few button clicks.

  1. Go to the Visual Studio for Windows feedback tool or Visual Studio for Mac feedback tool to report the issue
  2. Close this bug, and consider adding a link to the VS Feedback issue so that others can follow its activity there.

This issue will be automatically closed in 3 days if there are no further comments.

@ghost
Copy link

ghost commented Feb 6, 2023

This issue is being closed due to inactivity. If this issue is still affecting you, please follow the steps above to use the VS Feedback Tool to report the issue.

@ghost ghost closed this as completed Feb 6, 2023
@chabiss
Copy link
Contributor

chabiss commented Feb 8, 2023

This is probably related to the huge overhaul of the property setter specificity work as part of #11082

@chabiss chabiss reopened this Feb 8, 2023
@chabiss
Copy link
Contributor

chabiss commented Feb 8, 2023

This issue should not be closed. tag partner/hot-reload-xaml is accurate as an item to be track in the MAUI debot

@drasticactions
Copy link
Contributor

repro.mp4

I am testing on the current net7.0 maui with the current VSMac.

@drasticactions
Copy link
Contributor

drasticactions commented Feb 16, 2023

Changes within the VisualState itself are not reflected. As far as I can see, we're not sending any XAML Actions for these changes, so the app doesn't have a chance to update it.

スクリーンショット 2023-02-16 19 19 19

So if you change the individual value of the setter (Like the text color) nothing is sent to the application. If you change the entire list (As in, replace the entire VisualState or the VisualStateGroup) then it sends actions to replace the whole thing and then it reloads.

Having the style attached at all to a control shouldn't matter.

CC @etvorun.

@drasticactions drasticactions self-assigned this Feb 16, 2023
@drasticactions
Copy link
Contributor

Assigning myself to this for the moment so it's tracked, most likely this will be a XET issue but having this around is fine for visibility.

@chabiss chabiss removed the s/move-to-vs-feedback Tells automation to ask the person to use VS Feedback to report the issue label Feb 16, 2023
@rachelkang rachelkang added this to the Backlog milestone Feb 17, 2023
@ghost
Copy link

ghost commented Feb 17, 2023

We've moved this issue to the Backlog milestone. This means that it is not going to be worked on for the coming release. We will reassess the backlog following the current release and consider this item at that time. To learn more about our issue management process and to have better expectation regarding different types of issues you can read our Triage Process.

@jsuarezruiz
Copy link
Contributor Author

Not sure how to reproduce exactly, but modifying content from a ContentView used as CollectionView ItemTemplate
xaml-hot-relaod-issue

https://github.com/jsuarezruiz/netmaui-skateboard-ecommerce-app-challenge

@drasticactions
Copy link
Contributor

@jsuarezruiz I can't reproduce that on Android nor WinUI. I was able to make changes on the underlying ContentView and it showed fine. Was that on iOS? Do you have Logs?

@Zhanglirong-Winnie Zhanglirong-Winnie added s/triaged Issue has been reviewed s/try-latest-version Please try to reproduce the potential issue on the latest public version labels Jun 27, 2023
@ghost
Copy link

ghost commented Jun 27, 2023

Hi @jsuarezruiz. We have added the "s/try-latest-version" label to this issue, which indicates that we'd like you to try and reproduce this issue on the latest available public version. This can happen because we think that this issue was fixed in a version that has just been released, or the information provided by you indicates that you might be working with an older version.

You can install the latest version by installing the latest Visual Studio (Preview) with the .NET MAUI workload installed. If the issue still persists, please let us know with any additional details and ideally a reproduction project provided through a GitHub repository.

This issue will be closed automatically in 7 days if we do not hear back from you by then - please feel free to re-open it if you come back to this issue after that time.

@Zhanglirong-Winnie
Copy link
Collaborator

Verified this issue with Visual Studio Enterprise 17.7.0 Preview 2.0. Not repro on windows and android platform with sample project.
netmaui-movies.zip
13052

@ghost ghost closed this as completed Jul 4, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Aug 3, 2023
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-tooling XAML & C# Hot Reload, XAML Editor, Live Visual Tree, Live Preview, Debugging partner/hot-reload-xaml Issues impacting XAML Hot Reload experiences platform/android 🤖 platform/windows 🪟 s/triaged Issue has been reviewed s/try-latest-version Please try to reproduce the potential issue on the latest public version t/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants