Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resize and Downsize function in W2DImage class is not implemented on windows #16767

Open
MahmoudAlEssawi opened this issue Aug 15, 2023 · 3 comments
Labels
area-drawing Shapes, Borders, Shadows, Graphics, BoxView, custom drawing platform/windows 🪟 t/bug Something isn't working
Milestone

Comments

@MahmoudAlEssawi
Copy link

MahmoudAlEssawi commented Aug 15, 2023

public IImage Downsize(float maxWidth, float maxHeight, bool disposeOriginal = false)
{
throw new NotImplementedException();
}
public IImage Resize(float width, float height, ResizeMode resizeMode = ResizeMode.Fit,
bool disposeOriginal = false)
{
throw new NotImplementedException();
}

Description

public IImage Resize(float width, float height, ResizeMode resizeMode = ResizeMode.Fit,
		bool disposeOriginal = false)
	{
		throw new NotImplementedException();
	}

Steps to Reproduce

public IImage Resize(float width, float height, ResizeMode resizeMode = ResizeMode.Fit,
		bool disposeOriginal = false)
	{
		throw new NotImplementedException();
	}

Link to public reproduction project repository

No response

Version with bug

7.0.92

Is this a regression from previous behavior?

No, this is something new

Last version that worked well

Unknown/Other

Affected platforms

Windows

Affected platform versions

Windows 10.0.19041.0

Did you find any workaround?

No

Relevant log output

Not Implemented Exception
@MahmoudAlEssawi MahmoudAlEssawi added the t/bug Something isn't working label Aug 15, 2023
@Eilon Eilon added the area-drawing Shapes, Borders, Shadows, Graphics, BoxView, custom drawing label Aug 15, 2023
@drasticactions drasticactions added this to the Backlog milestone Aug 16, 2023
@ghost
Copy link

ghost commented Aug 16, 2023

We've added this issue to our backlog, and we will work to address it as time and resources allow. If you have any additional information or questions about this issue, please leave a comment. For additional info about issue management, please read our Triage Process.

@drasticactions
Copy link
Contributor

Downsize is partially implemented here:

public IImage Downsize(float maxWidthOrHeight, bool disposeOriginal = false)
{
if (Width > maxWidthOrHeight || Height > maxWidthOrHeight)
{
using (var memoryStream = new InMemoryRandomAccessStream())

@billreiss
Copy link

I have this issue too. It really kills my GraphicsView performance on Windows because I can't downsize the images.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-drawing Shapes, Borders, Shadows, Graphics, BoxView, custom drawing platform/windows 🪟 t/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants