Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[regression/8.0.0-preview.7.8842] - RefreshView does not hide spinner when IsRefreshing set to false. #16910

Closed
RobTF opened this issue Aug 22, 2023 · 4 comments · Fixed by #17062
Assignees
Labels
area-controls-refreshview RefreshView fixed-in-8.0.0-rc.1.9171 Look for this fix in 8.0.0-rc.1.9171 i/regression This issue described a confirmed regression on a currently supported version platform/android 🤖 t/bug Something isn't working
Milestone

Comments

@RobTF
Copy link

RobTF commented Aug 22, 2023

Description

The RefreshView control does not hide the spinner after the refresh operation completes and IsRefreshing is set to false. Same code worked fine in .NET 7.

Steps to Reproduce

  1. Clone this repo https://github.com/RobTF/mauiplay/tree/net8/CollectionViewIssue
  2. Run on Android
  3. Tap "Go to test page"
  4. Pull to refresh
  5. Observe refresh spinner does not disappear.

Link to public reproduction project repository

https://github.com/RobTF/mauiplay/tree/net8/CollectionViewIssue

Version with bug

8.0.0-preview.7.8842

Is this a regression from previous behavior?

Yes, this used to work in .NET MAUI

Last version that worked well

7.0.92

Affected platforms

Android

Affected platform versions

Android 13, Android 14

Did you find any workaround?

No

Relevant log output

No response

@RobTF RobTF added the t/bug Something isn't working label Aug 22, 2023
@RobTF
Copy link
Author

RobTF commented Aug 22, 2023

Currently has us blocked trying .NET 8 any further.

@samhouts samhouts added platform/android 🤖 area-controls-refreshview RefreshView i/regression This issue described a confirmed regression on a currently supported version labels Aug 22, 2023
@ghost ghost added the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label Aug 22, 2023
@samhouts samhouts changed the title 8.0.0-preview.7.8842 - RefreshView does not hide spinner when IsRefreshing set to false. [Regression from 7.0.92] [regression/8.0.0] - RefreshView does not hide spinner when IsRefreshing set to false. Aug 22, 2023
@samhouts samhouts added this to the .NET 8 GA milestone Aug 22, 2023
@samhouts
Copy link
Member

Something like this has been happening for a while, it seems. See #8926

@DM-98
Copy link

DM-98 commented Aug 22, 2023

@samhouts As it seems, it bugged out in .NET 6, then it has worked in:

  • .NET 7 (someone mentioned it worked)
  • .NET 8 Preview 5 (I personally used it and it worked)

And then it stopped at .NET 8 Preview 6 and 7.

I don't know why it's P/1, since Pull to refresh is a popular element used in apps.

@samhouts
Copy link
Member

p/1 is our highest priority (aside from p/0, which should be reserved for critical, "everything-is-on-fire" issues).

@samhouts samhouts changed the title [regression/8.0.0] - RefreshView does not hide spinner when IsRefreshing set to false. [regression/8.0.0-preview.7.8842] - RefreshView does not hide spinner when IsRefreshing set to false. Sep 18, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Oct 18, 2023
@samhouts samhouts added the fixed-in-8.0.0-rc.1.9171 Look for this fix in 8.0.0-rc.1.9171 label Jan 31, 2024
@Eilon Eilon removed the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label May 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-controls-refreshview RefreshView fixed-in-8.0.0-rc.1.9171 Look for this fix in 8.0.0-rc.1.9171 i/regression This issue described a confirmed regression on a currently supported version platform/android 🤖 t/bug Something isn't working
Projects
None yet
5 participants