Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash detection in build script is off-by-one #19703

Closed
Foda opened this issue Jan 4, 2024 · 0 comments · Fixed by #19697
Closed

Crash detection in build script is off-by-one #19703

Foda opened this issue Jan 4, 2024 · 0 comments · Fixed by #19697

Comments

@Foda
Copy link
Member

Foda commented Jan 4, 2024

Description

While looking at why the test crashing still allowed the test run to pass I noticed that we do actually check to see if the number of test categories matches:
Enable WinUI Controls Test Pipeline by PureWeen · Pull Request #17221 · dotnet/maui (github.com)

I made a debug build that prints out all the categories (Pipelines - Run 8.0.6-ci.net8.27224+pr.19697-sha.8a651754ae-azdo.104578 logs (azure.com)) which is 43 items, but the artifacts produced a build with only 42 xml files (it's missing TestResults-com_microsoft_maui_controls_devicetests_Frame.xml). You can also see it's missing from the test results page in ADO too (Pipelines - Run 8.0.6-ci.net8.27224+pr.19697-sha.8a651754ae-azdo.104578 (azure.com))

Here's frame test showing up in a non-crashed build: Pipelines - Run 8.0.6-ci.net8.27199+pr.19682-sha.957f043dce-azdo.104513 (azure.com)

Steps to Reproduce

No response

Link to public reproduction project repository

No response

Version with bug

8.0.3

Is this a regression from previous behavior?

No, this is something new

Last version that worked well

Unknown/Other

Affected platforms

Windows

Affected platform versions

No response

Did you find any workaround?

No response

Relevant log output

No response

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants