Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android: LineBreakMode="WordWrap" not working when label in popup on a row in a multi-row grid - 8.0.7-nightly.9897 #20092

Closed
DawidBester opened this issue Jan 23, 2024 · 4 comments
Assignees
Labels
area/layout 🔲 StackLayout, GridLayout, ScrollView, ContentView, AbsoluteLayout, FlexLayout, ContentPresenter i/regression This issue described a confirmed regression on a currently supported version platform/android 🤖 t/bug Something isn't working
Milestone

Comments

@DawidBester
Copy link

DawidBester commented Jan 23, 2024

Description

(not working for Android) Using 8.0.7-nightly.9897 (also tested 8.0.6-nightly.9755); LineBreakMode="WordWrap" not working when label placed in a popup as a row in a multi-row grid

(working) Using 8.0.6 and 8.0.3, Android and iOS17.2

nightly GA / SR1
image image

Steps to Reproduce

Run the sample project which uses 8.0.7-nightly.9897 and tap button "Show Label in Popup" for popup to show popup page and see label truncated text

Link to public reproduction project repository

https://github.com/DawidBester/LabelTextWrapTest

Version with bug

Nightly / CI build (Please specify exact version)

Is this a regression from previous behavior?

Yes, this used to work in .NET MAUI

Last version that worked well

8.0.6

Affected platforms

Android

Affected platform versions

Android

Did you find any workaround?

Use 8.0.6,

Unfortunately this 8.0.6 has issues with button CornerRadius=0 on Android which is a much more noticeable interface issue, so not an option: #19421

Relevant log output

No response

@DawidBester DawidBester added the t/bug Something isn't working label Jan 23, 2024
@DawidBester DawidBester changed the title LineBreakMode="WordWrap" not working when label in popup on a row in a multi-row grid - 8.0.7-nightly.9897 Android: LineBreakMode="WordWrap" not working when label in popup on a row in a multi-row grid - 8.0.7-nightly.9897 Jan 23, 2024
@jfversluis jfversluis added platform/android 🤖 i/regression This issue described a confirmed regression on a currently supported version labels Jan 23, 2024
@jsuarezruiz jsuarezruiz self-assigned this Jan 23, 2024
@jsuarezruiz
Copy link
Contributor

jsuarezruiz commented Jan 23, 2024

We started reviewing it https://github.com/dotnet/maui/tree/fix-20092. From first tests, getting the same result rolling back the changes in #14918 in the Android TextViewExtensions class.
image

@PureWeen PureWeen added this to the .NET 8 SR2 milestone Jan 23, 2024
@PureWeen
Copy link
Member

PureWeen commented Jan 23, 2024

It looks like this regressed between

8.0.4-nightly.9750 (12/14/2023)
and
8.0.4-nightly.9742 (12/13/2023)

most likely from this
#19349

@samhouts samhouts added the area/layout 🔲 StackLayout, GridLayout, ScrollView, ContentView, AbsoluteLayout, FlexLayout, ContentPresenter label Jan 25, 2024
@PureWeen
Copy link
Member

This issue isn't quite a regression.

For example, in 8.0.3 if you update the text after the popup is visible you'll see the same behavior of the text unwrapping itself.

It's more that #19349 triggers the ticking time bomb earlier

@PureWeen
Copy link
Member

Moved this to MCT for now
CommunityToolkit/Maui#1664

@github-actions github-actions bot locked and limited conversation to collaborators Feb 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/layout 🔲 StackLayout, GridLayout, ScrollView, ContentView, AbsoluteLayout, FlexLayout, ContentPresenter i/regression This issue described a confirmed regression on a currently supported version platform/android 🤖 t/bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

5 participants