Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shell navigation with modal page does not show title view #21321

Open
dk-mushiyoke opened this issue Mar 20, 2024 · 2 comments
Open

Shell navigation with modal page does not show title view #21321

dk-mushiyoke opened this issue Mar 20, 2024 · 2 comments
Labels
area-controls-shell Shell Navigation, Routes, Tabs, Flyout i/regression This issue described a confirmed regression on a currently supported version platform/android 🤖 s/triaged Issue has been reviewed s/verified Verified / Reproducible Issue ready for Engineering Triage t/bug Something isn't working
Milestone

Comments

@dk-mushiyoke
Copy link

Description

When using shell navigation to display a modal page, the title view does not show even with Shell.NavBarIsVisible set to True

As per #15498 the same issue should have been fixed in 8.0.0-preview.7.8842, however I am able to reproduce both in 8.0.6 and 8.0.7

Steps to Reproduce

  1. New maui project
  2. Add a new page with Shell.NavBarIsVisible="True" and Shell.PresentationMode="ModalAnimated"
  3. Register route for new page ("ModalPage" in repro)
  4. Hook up MainPage button clicked event to execute Shell.Current.GoToAsync("ModalPage");
  5. Build and run in android emulator, click button and observe the modal page

Link to public reproduction project repository

https://github.com/dk-mushiyoke/MauiModalTitleViewRepro

Version with bug

8.0.7 SR2

Is this a regression from previous behavior?

Yes, this used to work in .NET MAUI

Last version that worked well

8.0.0-preview.7.8842

Affected platforms

Android

Affected platform versions

Android 13

Did you find any workaround?

Using INavigation.PushModalAsync(new NavigationPage(new ModalPage())); instead of using shell navigation

Relevant log output

No response

@dk-mushiyoke dk-mushiyoke added the t/bug Something isn't working label Mar 20, 2024
@ninachen03 ninachen03 added s/verified Verified / Reproducible Issue ready for Engineering Triage s/triaged Issue has been reviewed i/regression This issue described a confirmed regression on a currently supported version labels Mar 20, 2024
@ninachen03
Copy link
Collaborator

Verified this issue with Visual Studio 17.10.0 Preview 2. and Microsoft.Maui.Controls: 8.0.20-nightly.10336+sha.d03a2c66aa-azdo.9265184. 8.0.10+0-sha.50a0144fa5-azdo.9223550, 8.0.3+2-sha.1ebb238ff3-azdo.8651303 all of them can repro

image

@Eilon Eilon added the area-controls-shell Shell Navigation, Routes, Tabs, Flyout label Mar 28, 2024
@PureWeen PureWeen added this to the Backlog milestone Apr 9, 2024
@kimhongka
Copy link

kimhongka commented May 24, 2024

Im getting the same issue. I cannot believe this has not fixed untill now.

MAUI document shows only about using GoToAsync way for Shell navigation instesad of using the NavigationPage way.

I can see the Modal from Shell GoToAsync, does Not show Shell.TitleView, and also the Tabbar as well. The Tabbar not showing issue is from Xamarin. I cannot believe the two issues are still there.
xamarin/Xamarin.Forms#13477

I think I need to use PushModal way to see if it works with Navigation titleview.... I have migrated two XF apps to MAUI(Prism navigation) already and this is my third migration. This time I wanted to use Shell.

I can do workaround like adding Title as customView or template etc, but this is not ideal. Please fix this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-controls-shell Shell Navigation, Routes, Tabs, Flyout i/regression This issue described a confirmed regression on a currently supported version platform/android 🤖 s/triaged Issue has been reviewed s/verified Verified / Reproducible Issue ready for Engineering Triage t/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants