Problem clearing VisualStates of collection items in a CollectionView, when the collection employs a DataTemplate generated with a DataTemplateSelector

[axa88]

Description

A problem clearing VisualStates of collection items in a CollectionView, when the collection employs a DataTemplate generated with a DataTemplateSelector

Meaning if an item in the collection has a VisualState applied, and then the Collection is cleared, when repopulating the collection, it is possible that the previous now cleared collection's VisualState will improperly be applied to the now new item collection.

Steps to Reproduce

1 Populate a CollectionView and select an item in the collection to apply some VisualState to the item.

2 Clear the Collection (Collection.Clear)
3 Repopulate the collection with NEW item(s).
4 Observe the VisualState lingering from the OLD item(s)

Link to public reproduction project repository

No response

Version with bug

8.0.40 SR5

Is this a regression from previous behavior?

Not sure, did not test other versions

Last version that worked well

Unknown/Other

Affected platforms

Windows

Affected platform versions

Windows 10.0.19041

Did you find any workaround?

In response to the aformentioned Collection (Collection.Clear) request, it is possible to subscribe to the subsequent CollectionChange event, to nullify and the reapply (the same) DataTemplateselector to the CollectionView's ItemTemplage:

    Items.CollectionChanged += (sender, notifyCollectionChangedEventArgs) =>
    {
        if (notifyCollectionChangedEventArgs.Action == NotifyCollectionChangedAction.Reset)
        {
	        SelectedItem = null;
	        SelectedItems = null;
    
	        ItemTemplate = null;
	        ItemTemplate = dataTemplateSelector;
        }
    };

This was also the work around to a somewhat related bug #21252

Relevant log output

No response

[github-actions]

Hi I'm an AI powered bot that finds similar issues based off the issue title.

Please view the issues below to see if they solve your problem, and if the issue describes your problem please consider closing this one and thumbs upping the other issue to help us prioritize it. Thank you!

Open similar issues:

• VisualState Setters not working properly on Windows for a CollectionView (#22104), similarity score: 0.79
• CollectionView visual state not updating selected [Windows] (#10595), similarity score: 0.77

Closed similar issues:

• Problem (re)applying DataTemplates generated with a DataTemplateSelector, to collection items that are added to a CollectionView after the Collection is Cleared (#21252), similarity score: 0.86
• VisualStates are not being applied to items in a CollectionView using DataTemplates in Release Mode (#9756), similarity score: 0.78
• DataTemplateSelector on CollectionView is completely broken - templates don't match BindingContext (#12988), similarity score: 0.77

Note: You can give me feedback by thumbs upping or thumbs downing this comment.

[axa88]

@

Honestly why wait 7 days. Just close it now as you guys apparently have no inclination to accept it for what it is.

There are dozens of bugs filed screaming that VisualStates are broken, and nothing is getting fixed, so i don't imagine this one more bug is going to help anything. Just close it. Last bug I bother filing about it