Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Background set to Transparent doesn't have the same behavior as BackgroundColor = Transparent #22769

Open
pictos opened this issue May 31, 2024 · 6 comments
Labels
area-controls-shell Shell Navigation, Routes, Tabs, Flyout platform/iOS 🍎 s/triaged Issue has been reviewed s/verified Verified / Reproducible Issue ready for Engineering Triage t/bug Something isn't working
Milestone

Comments

@pictos
Copy link
Contributor

pictos commented May 31, 2024

Description

In my attempt to make my modal page transparent, I found this issue where Background = Transparent doesn't have the desired effect, but BackgroundColor = Transparent does have. They should have the same behavior, no?

With Background = "Transparent":

With BackgroundColor= "Transparent":

Steps to Reproduce

  1. Open the repro project
  2. Click on the button to do a Modal Navigation
  3. You can't see the underline page (If using Background = Transparent)

Link to public reproduction project repository

https://github.com/pictos/BackgroundTransparentIssue

Version with bug

8.0.40 SR5

Is this a regression from previous behavior?

Not sure, did not test other versions

Last version that worked well

Unknown/Other

Affected platforms

iOS

Affected platform versions

No response

Did you find any workaround?

Use BackgroundColor instead

Relevant log output

No response

@pictos pictos added the t/bug Something isn't working label May 31, 2024
Copy link
Contributor

Hi I'm an AI powered bot that finds similar issues based off the issue title.

Please view the issues below to see if they solve your problem, and if the issue describes your problem please consider closing this one and thumbs upping the other issue to help us prioritize it. Thank you!

Open similar issues:

Closed similar issues:

Note: You can give me feedback by thumbs upping or thumbs downing this comment.

@Zhanglirong-Winnie Zhanglirong-Winnie added s/verified Verified / Reproducible Issue ready for Engineering Triage s/triaged Issue has been reviewed labels Jun 3, 2024
@Zhanglirong-Winnie
Copy link
Collaborator

Verified this issue with Visual Studio 17.11.0 Preview 1.1(8.0.40). Can repro on iOS platform with sample project.

@kubaflo
Copy link
Collaborator

kubaflo commented Jun 3, 2024

So it looks like setting the background color gives the effect I would expect. I wonder if, currently, the result of setting background to transparent is what it is supposed to be or not🤔

@jsuarezruiz jsuarezruiz added this to the Backlog milestone Jun 4, 2024
@mattleibow
Copy link
Member

The behaviour is supposed to be exactly the same. In Core code we basically have a single property that is

Background => Background ?? BackgroundColor

If there is a difference in behaviour, it is interesting.

This would happen if in one style you are using Background and another you are using BackgroundColor. I really want to deprecate/remove the BackgroundColor because it is more limited and causes this type of confusion.

If you have a look at styles, do you perhaps have a mixed usage of property.

@mattleibow mattleibow added the s/needs-info Issue needs more info from the author label Jun 20, 2024
Copy link
Contributor

Hi @pictos. We have added the "s/needs-info" label to this issue, which indicates that we have an open question for you before we can take further action. This issue will be closed automatically in 7 days if we do not hear back from you by then - please feel free to re-open it if you come back to this issue after that time.

@mattleibow
Copy link
Member

Oh wait, is a whole new page with shell navigation. I wonder if there is some missing logic in page or shell to respect background.

@mattleibow mattleibow added area-controls-shell Shell Navigation, Routes, Tabs, Flyout and removed area-controls-modal s/needs-info Issue needs more info from the author labels Jun 20, 2024
@samhouts samhouts removed s/verified Verified / Reproducible Issue ready for Engineering Triage s/triaged Issue has been reviewed labels Jul 3, 2024
@samhouts samhouts added s/verified Verified / Reproducible Issue ready for Engineering Triage s/triaged Issue has been reviewed labels Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-controls-shell Shell Navigation, Routes, Tabs, Flyout platform/iOS 🍎 s/triaged Issue has been reviewed s/verified Verified / Reproducible Issue ready for Engineering Triage t/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

7 participants