Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Platform Specifics are not working #5856

Closed
44 of 50 tasks
jsuarezruiz opened this issue Apr 6, 2022 · 21 comments
Closed
44 of 50 tasks

Platform Specifics are not working #5856

jsuarezruiz opened this issue Apr 6, 2022 · 21 comments
Assignees
Labels
area/controls 🎮 Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor fixed-in-6.0.312 Look for this fix in 6.0.312! high It doesn't work at all, crashes or has a big impact. p/1 Work that is critical for the release, but we could probably ship without platform/android 🤖 platform/iOS 🍎 platform/macOS 🍏 macOS / Mac Catalyst platform/windows 🪟 s/triaged Issue has been reviewed s/verified Verified / Reproducible Issue ready for Engineering Triage t/bug Something isn't working
Milestone

Comments

@jsuarezruiz
Copy link
Contributor

jsuarezruiz commented Apr 6, 2022

Description

Defined Platform Specifics are not working on .NET MAUI.

Android

  • Button UseDefaultPadding and UseDefaultShadow.
  • Entry ImeOptions.
  • ImageButton IsShadowEnabled, ShadowColor and ShadowRadius. With the new Shadows API we can achieve the same effect also on all platforms.
  • ListView IsFastScrollEnabled.
  • NavigationPage BarHeight.
  • Page SendDisappearingEventOnPause, SendAppearingEventOnResume and ShouldPreserveKeyboardOnResume. With the new lifecycle events API we can achieve the same.
  • Application WindowSoftInputModeAdjust.
  • SwipeView SwipeTransitionMode.
  • TabbedPage IsSwipePagingEnabled.
  • TabbedPage IsSmoothScrollEnabled.
  • ViewCell IsContextActionsLegacyModeEnabled. No longer necessary.
  • VisualElement Elevation. With the new ZIndex property can achieve something similar.
  • WebView MixedContentMode, EnableZoomControls and DisplayZoomControls.

iOS

Windows

More information: https://docs.microsoft.com/en-us/xamarin/xamarin-forms/platform/

Steps to Reproduce

Verified with the .NET MAUI Gallery.

To verify it just download https://github.com/davidbritch/dotnet-maui-samples/tree/main/PlatformIntegration/PlatformSpecifics
Launch the App in any platform and test any samples.

Version with bug

Preview 14 (current)

Last version that worked well

Unknown/Other

Affected platforms

iOS, Android, Windows, macOS

Affected platform versions

Windows SDK 10.0.17134.0, Android 11, iOS 15

Did you find any workaround?

No response

Relevant log output

No response

@jsuarezruiz jsuarezruiz added t/bug Something isn't working high It doesn't work at all, crashes or has a big impact. s/verified Verified / Reproducible Issue ready for Engineering Triage labels Apr 6, 2022
@jsuarezruiz jsuarezruiz self-assigned this Apr 6, 2022
@jsuarezruiz jsuarezruiz added this to the 6.0.300-rc.2 milestone Apr 6, 2022
@davidbritch
Copy link
Contributor

I think we could also remove:

Android: TabbedPage.BarItemColor/BarSelectedItemColor (justification: TabbedPage has SelectedTabColor/UnselectedTabColor properties).
Android: ViewCell.IsContextActionsLegacyModeEnabled
Android: VisualElement.Elevation (justification: MAUI has ZIndex property).
iOS: Application.EnableAccessibilityScalingForNamedFontSizes (justification: there are no named font sizes).

I'm unsure whether this can be removed:

iOS: Application.HandleControlUpdatesOnMainThread (can't remember why this was needed).

@Eilon Eilon added the area/controls 🎮 Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label Apr 13, 2022
@Redth Redth modified the milestones: 6.0.300-rc.2, 6.0.300-rc.3 Apr 20, 2022
@Redth Redth modified the milestones: 6.0.300-rc.3, 6.0.300 Apr 27, 2022
@davidortinau davidortinau added the p/1 Work that is critical for the release, but we could probably ship without label Apr 30, 2022
@Redth Redth added p/2 Work that is important, but not critical for the release and removed p/1 Work that is critical for the release, but we could probably ship without labels May 3, 2022
@mattleibow mattleibow reopened this May 9, 2022
@mattleibow mattleibow reopened this May 9, 2022
@rmarinho rmarinho reopened this May 11, 2022
@samhouts samhouts modified the milestones: 6.0.300, 6.0.300-servicing May 12, 2022
@Redth Redth modified the milestones: 6.0-servicing, .NET 8 Planning Aug 30, 2022
@victorsigga
Copy link

Hello guys, toolbar placement on UWP is on the list of features to be developed soon ?

@davidortinau davidortinau removed the User Story A single user-facing feature. Can be grouped under an epic. label Apr 11, 2023
@OMendozaG

This comment was marked as off-topic.

@NonameMissingNo

This comment was marked as off-topic.

@mattleibow
Copy link
Member

@PureWeen didn't we implement safe areas already... Is just the platform specific not hooked up because we now have the general feature on all the things? @hartez ?

@samhouts samhouts added p/1 Work that is critical for the release, but we could probably ship without and removed p/2 Work that is important, but not critical for the release labels Apr 24, 2023
@samhouts samhouts modified the milestones: Backlog, .NET 8 May 24, 2023
@samhouts samhouts modified the milestones: .NET 8, .NET 8 GA Jul 12, 2023
@Zhanglirong-Winnie Zhanglirong-Winnie added s/verified Verified / Reproducible Issue ready for Engineering Triage s/triaged Issue has been reviewed labels Sep 25, 2023
@Zhanglirong-Winnie
Copy link
Collaborator

Verified this issue with Visual Studio Enterprise 17.8.0 Preview 2.0. Can be repro via sample project.
dotnet-maui-samples-main.zip

@d2dyno1
Copy link

d2dyno1 commented Nov 28, 2023

When can we expect wider customization for RootNavigationView? I'm looking to change "PaneDisplayMode" as well as "PaneTitle" on WinUI's NavigationView or at least use a workaround which would also move the hamburger button out of the titlebar area

@jsuarezruiz
Copy link
Contributor Author

Because NavigationPage reuse a lot of code from Xamarin.Forms renderer, NavigationPage BarHeight is working:
image
Marked as done.

@jsuarezruiz
Copy link
Contributor Author

We already have specific issues created by the pending platform specifics. Close this big issue in favor of the specific ones.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/controls 🎮 Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor fixed-in-6.0.312 Look for this fix in 6.0.312! high It doesn't work at all, crashes or has a big impact. p/1 Work that is critical for the release, but we could probably ship without platform/android 🤖 platform/iOS 🍎 platform/macOS 🍏 macOS / Mac Catalyst platform/windows 🪟 s/triaged Issue has been reviewed s/verified Verified / Reproducible Issue ready for Engineering Triage t/bug Something isn't working
Projects
None yet
Development

No branches or pull requests