Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LayoutChildren Method does not respect the values that are given in #7668

Open
AswinPG opened this issue Jun 1, 2022 · 11 comments
Open

LayoutChildren Method does not respect the values that are given in #7668

AswinPG opened this issue Jun 1, 2022 · 11 comments
Labels
area-layout StackLayout, GridLayout, ContentView, AbsoluteLayout, FlexLayout, ContentPresenter partner Issue or Request from a partner team platform/android 🤖 s/needs-attention Issue has more information and needs another look s/triaged Issue has been reviewed s/verified Verified / Reproducible Issue ready for Engineering Triage t/bug Something isn't working
Milestone

Comments

@AswinPG
Copy link

AswinPG commented Jun 1, 2022

Description

It's my understanding that by overriding the LayoutChildern of Contentpage let'sus to write custom code for layouting it's children, I am trying to layout the children such a way to avoid rendering over the android Navbar and the camera cutout but maui keeps placing them over the cutout/Navbar even if i give fixed values to layoutChildren method.

I am not really sure if this is how LayoutChildren is supposed to work. Please advise if I am wrong

Steps to Reproduce

  1. Create new Maui App
  2. create a page that inherits from ContentPage
  3. Override the LayoutChildren method and try to give your own fixed size
  4. The given size is not respected, instead the whole display is used

Version with bug

6.0 (current)

Last version that worked well

Unknown/Other

Affected platforms

Android

Affected platform versions

Android 12

Did you find any workaround?

No

Relevant log output

No response

@AswinPG AswinPG added s/needs-verification Indicates that this issue needs initial verification before further triage will happen t/bug Something isn't working labels Jun 1, 2022
@jsuarezruiz jsuarezruiz added the area-layout StackLayout, GridLayout, ContentView, AbsoluteLayout, FlexLayout, ContentPresenter label Jun 1, 2022
@AswinPG

This comment was marked as off-topic.

@davidortinau davidortinau added the partner Issue or Request from a partner team label Jun 6, 2022
@jfversluis jfversluis added platform/android 🤖 and removed s/needs-verification Indicates that this issue needs initial verification before further triage will happen labels Jun 13, 2022
@kristinx0211
Copy link

@AswinPG Would you be able to add a little reproduction project that shows this?

@kristinx0211 kristinx0211 added the s/needs-repro Attach a solution or code which reproduces the issue label Jun 20, 2022
@ghost
Copy link

ghost commented Jun 20, 2022

Hi @AswinPG. We have added the "s/needs-repro" label to this issue, which indicates that we require steps and sample code to reproduce the issue before we can take further action. Please try to create a minimal sample project/solution or code samples which reproduce the issue, ideally as a GitHub repo that we can clone. See more details about creating repros here: https://github.com/dotnet/maui/blob/main/.github/repro.md

This issue will be closed automatically in 7 days if we do not hear back from you by then - please feel free to re-open it if you come back to this issue after that time.

@kristinx0211 kristinx0211 added the s/triaged Issue has been reviewed label Jun 20, 2022
@ghost ghost added s/needs-attention Issue has more information and needs another look and removed s/needs-repro Attach a solution or code which reproduces the issue labels Jun 20, 2022
@AswinPG
Copy link
Author

AswinPG commented Jun 20, 2022

MauiApp5.zip

@kristinx0211
Copy link

can repro this issue with vs 17.3.0 Preview 3.0 [32620.181.main], set value for LayoutChildren does not work.

@kristinx0211 kristinx0211 added the s/verified Verified / Reproducible Issue ready for Engineering Triage label Jun 21, 2022
@hartez hartez self-assigned this Jun 21, 2022
@PureWeen PureWeen added this to the 6.0-servicing milestone Jun 28, 2022
@hartez hartez removed their assignment Aug 2, 2022
@Redth Redth modified the milestones: 6.0-servicing, Backlog Aug 30, 2022
@ghost
Copy link

ghost commented Aug 30, 2022

We've moved this issue to the Backlog milestone. This means that it is not going to be worked on for the coming release. We will reassess the backlog following the current release and consider this item at that time. To learn more about our issue management process and to have better expectation regarding different types of issues you can read our Triage Process.

@samhouts samhouts removed s/verified Verified / Reproducible Issue ready for Engineering Triage s/triaged Issue has been reviewed labels Apr 5, 2023
@XamlTest XamlTest added s/verified Verified / Reproducible Issue ready for Engineering Triage s/triaged Issue has been reviewed labels May 12, 2023
@XamlTest
Copy link
Collaborator

Verified this on Visual Studio Enterprise 17.6.0 Preview 7.0. Repro on Android 13.0 with below Project:
7668.zip

image

@Alex-Dobrynin
Copy link

this is still an issue. will this be fixed some day? or this repo is abandoned?

@roubachof
Copy link

I guess better migrate to new layout implementation: #7613 (comment)

@PureWeen
Copy link
Member

If you override ArrangeOverride and MeasureOverride you can provide custom implementations of how children are laid out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-layout StackLayout, GridLayout, ContentView, AbsoluteLayout, FlexLayout, ContentPresenter partner Issue or Request from a partner team platform/android 🤖 s/needs-attention Issue has more information and needs another look s/triaged Issue has been reviewed s/verified Verified / Reproducible Issue ready for Engineering Triage t/bug Something isn't working
Projects
None yet
Development

No branches or pull requests