Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Expand BuildCheck editorconfig allowable syntax #10232

Open
baronfel opened this issue Jun 13, 2024 · 2 comments
Open

[Feature Request]: Expand BuildCheck editorconfig allowable syntax #10232

baronfel opened this issue Jun 13, 2024 · 2 comments

Comments

@baronfel
Copy link
Member

baronfel commented Jun 13, 2024

Summary

EditorConfig settings for BuildChecks have rigid rules:

  • casing matters for properties
  • not all Roslyn severities are available, but the docs declare it to be so

Background and Motivation

Ease of use/things I banged my head against today

Proposed Feature

I'd like to see:

  • the IsEnabled property should support enabled as well
  • casing should be case-insensitive
  • a severity of None (also, none) should be allowed to disable a rule (this is in line with the desire for case-insensitivity)

Alternative Designs

No response

@f-alizada
Copy link
Contributor

Thank you!
I'm going to update the usage, however would like clarify: which values were case sensitive?
Trying to reproduce:

[*.csproj]
build_check.BC0101.IsEnabled=TRUE
build_check.BC0101.SEVERITY=ERROR

And the configuration applied correctly, am I missing something?

@f-alizada f-alizada self-assigned this Jun 14, 2024
@baronfel
Copy link
Member Author

For case sensitivity I agree that the values are fine, it was the case sensitivity of the property keys that was frustrating - convention elsewhere seems to be lowercase property keys (meaning don't let .NET's Pascal case obsession leak to the editor config file).

@AR-May AR-May added the triaged label Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants