Fix bug: Terminal logger Copy task retries #10296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rainersigwald
approved these changes
Jun 26, 2024
There was a problem hiding this comment.
Works for me! @baronfel this is going with the "special-case this code and punt the logging-API question" approach, which feels right to me at the moment.
|
This is fine to fix the immediate problem, but I would like us to log an item to push for a 'full' fix - these messages looks noisy with the shared file prefix, and could overall do with a bit of cleanup presentation-wise when rendering in Terminal Logger. They look dated compared to how we render the project-specific errors. |
MichalPavlik
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9658
Old behavior
New behavior