Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import Project path when evaluated to more than 256 chars fails rather than skipping to import #1613

Closed
shahabhijeet opened this issue Jan 26, 2017 · 2 comments
Labels

Comments

@shahabhijeet
Copy link

shahabhijeet commented Jan 26, 2017

For e.g. let's assume here is an import as below

<PackageName>ReallyLongString</PackageName>
<Scope>Foo</Scope>
<Import Project="$(LibrarySourceFolder)\$(Scope)\**\*$(PackageName).nuget.proj" Condition=" '$(Scope)' != 'all' " />

If the entire path is less than 256 and unable to evaluate to a valid path, it skips to import.
But if the entire path exceeds 256, it errors out saying, cannot import and prints the unevaluated literal path.

Actual: Errors out and prints literal unevaluated path
Expected: Skip importing project even if the path exceeds 256
Have consistent behavior in both cases.

@rainersigwald
Copy link
Member

This is a combination of #53 ("MAX_PATH exists") and #406 ("wildcard expansion returns the input when a recursive glob exceeds MAX_PATH").

@rainersigwald
Copy link
Member

Closing since we have those other two issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants