Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add auto-imported Directory.build.props/targets to $(MSBuildAllProjects) automatically #1949

Closed
dasMulli opened this issue Apr 6, 2017 · 4 comments
Labels

Comments

@dasMulli
Copy link
Contributor

dasMulli commented Apr 6, 2017

Directory.build.props/.targets is a great feature, but when you start to add configuration properties in there and don't really know much about how incremental build works in msbuild, you're going to hit "weird issues".
I'd like the auto-imported files to be automatically added to $(MSBuildAllProjects) so that targets using it as inputs will pick up changes automatically. It's easy to forget the necessary preamble when you start out with an empty msbuild file.. Also, this helps reducing your project build files to the absolute minimum.

@rainersigwald
Copy link
Member

Great idea, tracked by #1299. Closing this as a duplicate.

@dasMulli
Copy link
Contributor Author

#1299 is probably a little more invasive (but I'd like to see it).
For these special project files, I was thinking about adding it directly in Microsoft.Common.props/.targets.

@rainersigwald
Copy link
Member

Oh, adding it next to the import with the same conditions? That's clever! And it should be fairly low-impact. Want to submit a PR?

@rainersigwald rainersigwald reopened this Apr 19, 2017
@dasMulli
Copy link
Contributor Author

Love to. will do so over the next days/weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants